Rotate fullscreen media using sensor orientation even when rotation lock is active
Categories
(Firefox for Android :: Browser Engine, defect)
Tracking
()
People
(Reporter: gl, Unassigned)
Details
From github: https://github.com/mozilla-mobile/android-components/issues/10433.
I suppose this may have been a philosophical choice, but I thought I would at least bring up the issue.
Personally, I always keep rotation lock on because I want to keep reading articles in portrait mode even when laying sideways. However, when watching a video, I would like the video to be in landscape mode (this is currently supported) and ideally be rotated according to the device orientation (this is not the current behavior). This contrasts to the behavior on other browsers such as the chrome mobile app.
Unless I am mistaken, I believe this behavior is defined in https://github.com/mozilla-mobile/android-components/blob/master/components/feature/media/src/main/java/mozilla/components/feature/media/fullscreen/MediaSessionFullscreenFeature.kt where orientation is set to
ActivityInfo.SCREEN_ORIENTATION_USER_PORTRAIT
andActivityInfo.SCREEN_ORIENTATION_USER_LANDSCAPE
instead ofActivityInfo.SCREEN_ORIENTATION_SENSOR_PORTRAIT
andActivityInfo.SCREEN_ORIENTATION_SENSOR_LANDSCAPE
.Was this done intentionally?
┆Issue is synchronized with this Jira Task
Change performed by the Move to Bugzilla add-on.
Comment 1•3 years ago
|
||
The severity field is not set for this bug.
:cpeterson, could you have a look please?
For more information, please visit auto_nag documentation.
Updated•3 years ago
|
Updated•2 years ago
|
Description
•