1796488 - Expose slow script observer

Status: NEW

(Firefox for Android :: Browser Engine, task)

Description

[Chris Peterson [:cpeterson]]

From github: https://github.com/mozilla-mobile/android-components/issues/4437.

GeckoView added a new function onSlowScript to ContentDelegate which allows handling of slow and hung scripts. We have to expose that through AC

┆Issue is synchronized with this Jira Task

Change performed by the Move to Bugzilla add-on.

Comment 1

[BMO Automation]

Attachment: GitHub Pull Request

Comment 2

[BugBot [:suhaib / :marco]]

The severity field is not set for this bug.
:cpeterson, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 3

[Kevin Brosnan [Ex-Mozilla]]

Looks like the pr was closed out as part of the migration.

Comment 4

[Kevin Brosnan [Ex-Mozilla]]

Talked with Alexandru and the PR is the new one in this bug.

Comment 5

[Kaya [:kaya]]

Hi Alexandru. Are you still working on this ticket? It is marked P1 for now. You can change it accordingly.

Comment 6

[Alexandru Putanu [:aputanu]]

Hi, this is currently waiting for designs from UX. I'll mark it as P2.

Comment 8

[Joe M [:jmahon]]

:aputanu (Sorry, I know we talked about this last week, but I've lost track of the records of that convo) Can you summarize what you need from UX so I can help facilitate that request?

Comment 9

[Joe M [:jmahon]]

NEVERMIND! Just realized this is a duplicate ticket of https://mozilla-hub.atlassian.net/browse/FXDROID-39, which does, in fact, already have that info.

Comment 10

[Joe M [:jmahon]]

What we need from design is a response to this question from the original Github issue:

I started working on the issue that exposes the onSlowScript callback in AC.

Since the API returns a SlowScriptResponse, saying whether we want the slow script to continue running or to stop it, how should we notify the user? and how would the user interact with the notification to decide between stop and continue for the slow script?

Another question I have is whether or not the slow script feature that will be used by Fenix will be lifecycle aware or not.

@topotropic, is there any design or specs about how this should look and behave?

It's possible a designer (Nicole or Jeff maybe?) already looked into this a long time ago, there are a few overlapping tickets that may have been part of this:

• An accidental dupe of this one: Bug 1807309
• The original github issue: Issue 14959 (the Jira clone of which includes this reference to the idea that Jeff may have looked at this prior to Jan 31 2023)
• The A-C github issue: Issue 4437

Circling this back to the UX team now, after having re-discovered some of the original context - sorry for the confusion over the past 1.5 years)

Comment 11

[Joe M [:jmahon]]

Copying an old comment from the original ticket just to streamline conversation in one place:

Oh, Jeff, it looks like you had been assigned to a “dupe” ticket ( https://mozilla-hub.atlassian.net/browse/FNXV2-6717 ) - this might just be some bookkeeping confusion.

Did you already have a chance to review that? Alex is looking for UX resolution on this, but it’s a pretty stale PR, so I’m not sure who has context on it at this point.

Comment 12

[BugBot [:suhaib / :marco]]

The bug assignee is inactive on Bugzilla, so the assignee is being reset.

Comment 13

[Joe M [:jmahon]]

Jeff - this bug has languished for the past year because of some confusing bookkeeping. Can you help resolve the open question above?

Comment 14

[jguerrero]

@Joe - Let me do some backtracking on this / sync with Nicole and I'll try to get back to you next week if that's okay - thanks!

Comment 15

[Chris Peterson [:cpeterson]]

Clearing Priority so we can reprioritize these bugs relative to our ux-fun-2024 bugs.