1796520 - Don't push and pop savedRegisters_

Status: RESOLVED INVALID

(Core :: JavaScript Engine, defect)

Description

[LuYahan]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/104.0.5112.102 Safari/537.36 Edg/104.0.1293.70

Steps to reproduce:

In SMRegExpMacroAssembler::stackOverflowHandler(), masm uses temp0_,temp1_ and backtrack_stack_pointer_. But don't push and pop savedRegisters_.

Actual results:

Don't push

Expected results:

Push and pop savedRegisters_

Comment 1

[LuYahan]

Attachment: Bug 1796520: Push and Pop savedRegisters_ in stackOverflowHandler r=iain

Comment 2

[Iain Ireland [:iain]]

Thanks for the bug report / patch!

However, I don't think this is necessary. I've left comments on the patch to explain why, and marked it as "needs revision". If I'm missing something, let me know. If not, you should be able to close the patch with the "Abandon revision" option in the action menu at the bottom.