1796570 - gfx.color_management.mode should be 2 for GeckoView

Status: RESOLVED FIXED

(GeckoView :: General, task, P1)

Description

[Takanori MATSUURA]

With the fix of bug 488800, ICCv4 is enabled on all channels on all OS.
And "gfx.color_management.mode" is set to 2 in modules/libpref/init/StaticPrefList.yaml.

However mobile/android/app/mobile.js overwrites "gfx.color_management.mode" to 0 in which means ICCv4 is off.

This overwrite should be removed.

Comment 1

[Jonathan Almeida [:jonalmeida]]

Is this something that you're going to be working on?

Comment 2

[Takanori MATSUURA]

(In reply to Jonathan Almeida [:jonalmeida] from comment #1)

Is this something that you're going to be working on?

No.
If you want to work on, that's great.

Comment 3

[Jonathan Almeida [:jonalmeida]]

This is a one-liner change that someone in our team will pick up during our next sprint planning.

Marking it as a good-first-bug as well in case new contributors are interested in this as well.

Comment 4

[Titouan Thibaud [:tthibaud]]

I'd like to take this one

Comment 5

[Titouan Thibaud [:tthibaud]]

Attachment: Bug 1796570 - Stop overwritting the value of gfx.color_management.mode on Android r=#geckoview-reviewers

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

This good-first-bug hasn't had any activity for 2 months, it is automatically unassigned.
For more information, please visit auto_nag documentation.

Comment 7

[Dianna Smith [:diannaS]]

not sure this should be unassigned. looks like the only thing pending here is the questions on the patch, adding NI

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/20b2f1dab9b3
Stop overwritting the value of gfx.color_management.mode on Android r=geckoview-reviewers,calu,jnicol

Comment 9

[Titouan Thibaud [:tthibaud]]

Thanks Dianna! I finally received the approval I was waiting for, and just landed the patch.

Comment 10

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5005cca1dd2e
Backed out changeset 20b2f1dab9b3 for causing failures at canvas-display-p3-drawImage-ImageBitmap-Blob.html. CLOSED TREE

Comment 11

[Atila Butkovits]

Backed out for causing failures at canvas-display-p3-drawImage-ImageBitmap-Blob.html.

Backout link: https://hg.mozilla.org/integration/autoland/rev/5005cca1dd2e29a172b73291611eb6dc9df04381

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=20b2f1dab9b3c2bb081f3959ce2747143664302c&selectedTaskRun=G4NTr29DRaW9ZjDNhm8mBA.0

Failure log:
wpt failure - https://treeherder.mozilla.org/logviewer?job_id=412763948&repo=autoland&lineNumber=5050
wr6 failure - https://treeherder.mozilla.org/logviewer?job_id=412763391&repo=autoland&lineNumber=5080

Comment 12

[Titouan Thibaud [:tthibaud]]

Thanks Atila Butkovits!

When I took this bug initially I didn't realize it had bigger implications than just changing one line. I don't know the graphics components enough to confidently update the tests and make sure anything was broken. Furthermore, this bug doesn't seem to have a high priority, so I'll unassigned me from this bug.

Comment 13

[Takanori MATSUURA]

(In reply to Titouan Thibaud [:tthibaud] from comment #12)

Thanks Atila Butkovits!

When I took this bug initially I didn't realize it had bigger implications than just changing one line. I don't know the graphics components enough to confidently update the tests and make sure anything was broken. Furthermore, this bug doesn't seem to have a high priority, so I'll unassigned me from this bug.

We need to update canvas-display-p3-drawImage-ImageBitmap-Blob.html.ini properly.

Core::GFX: Color Management people may help us.

Comment 14

[Makoto Kato [:m_kato]]

Attachment: Bug 1796570 - Part 2. Update WPT results after gfx.color_management.mode=2. r=#gfx-reviewers

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c07f950561db
Stop overwritting the value of gfx.color_management.mode on Android r=geckoview-reviewers,calu,jnicol
https://hg.mozilla.org/integration/autoland/rev/9ed30d5056e5
Part 2. Update WPT results after gfx.color_management.mode=2. r=gfx-reviewers,jnicol

Comment 16

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/c07f950561db
https://hg.mozilla.org/mozilla-central/rev/9ed30d5056e5

Comment 17

[Chris Peterson [:cpeterson]]

Makoto, I see some WPT tests that had been failing on Android are now passing. Do you think we should uplift this pref change to Beta 113? Does this change improve the user experience for real web pages or just WPT corner cases? How risky is this change?

Comment 18

[Makoto Kato [:m_kato]]

(In reply to Chris Peterson [:cpeterson] from comment #17)

Makoto, I see some WPT tests that had been failing on Android are now passing. Do you think we should uplift this pref change to Beta 113? Does this change improve the user experience for real web pages or just WPT corner cases? How risky is this change?

I don't think that this is risky. WPT failures are color management tests. So it depends on gfx.color_management.mode preferences. This fix improves color management of JPEG image etc in web pages.

But I don't think that this should be uplifted. This fix is new feature issue for GeckoView, so we need something feedback for this change.