Closed Bug 1796757 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 36584 - Revert "Mark OOFs for paint invalidation on layout cache hit."

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox108 fixed)

Status:
RESOLVED FIXED
Milestone:
108 Branch
Tracking Flags:
Tracking Status
firefox108 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 36584 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/36584
Details from upstream follow.

Morten Stenshorne <mstensho@chromium.org> wrote:

Revert "Mark OOFs for paint invalidation on layout cache hit."

This reverts commit d37eccd5e286921e09b81268e1a5dd3857e38bc9.

Reason for revert: Performance regression - see crbug.com/1376975

Original change's description:

Mark OOFs for paint invalidation on layout cache hit.

This is a work-around for cases where an OOF is missed during
LayoutObject subtree tree walk in pre-paint (with block fragmentation),
so that we end up in PrePaintTreeWalk::WalkMissedChildren(). If any of
the ancestors of the OOF actually moved, pre-paint will force a deep
subtree walk, but that's not going to help the OOF if it's missed.

Bug: 1375232
Change-Id: I57ae0c78c8c5435daba5c6d7971041c9421c006b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3963036
Reviewed-by: Xianzhu Wang \<wangxianzhu@chromium.org>
Commit-Queue: Morten Stenshorne \<mstensho@chromium.org>
Reviewed-by: Ian Kilpatrick \<ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1061456}

Bug: 1375232
Change-Id: I003895b83778d6dd8f4d561e79f8f173a66310d5

Reviewed-on: https://chromium-review.googlesource.com/3970619
WPT-Export-Revision: 183a52352122a65e127e688c1ab4595cc649a373

PR 36584 applied with additional changes from upstream: 4aaafe621eca1ef03d7fa3ae1f2e93e6799e9cd6
The PR was not expected to affect any tests, but the try push wasn't a success. Check the try results for infrastructure issues
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/355913721857 [wpt PR 36584] - Revert "Mark OOFs for paint invalidation on layout cache hit.", a=testonly
Test result changes from PR not available.

https://hg.mozilla.org/mozilla-central/rev/355913721857

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox108: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 108 Branch
You need to log in before you can comment on or make changes to this bug.