179676 - Increase the Go menu history list size

Status: RESOLVED FIXED

(Camino Graveyard :: History, enhancement)

Description

[Stephane Moureau]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X; en-US; rv:1.0.1) Gecko/20021109 Chimera/0.6+
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X; en-US; rv:1.0.1) Gecko/20021109 Chimera/0.6+

If you go to a lot of different pages then use the Go menu list to go back to a
previously visited page, after several go back, the Go menu list has forgot
where you have been.
I don't know if this can be increased in the current build 1109 but it would be
great to be able to specify how many pages will be stored in the Go menu history
list, even if it's by modifying a .js variable (no GUI).

Reproducible: Always

Steps to Reproduce:

Comment 1

[Kathleen :Brade]

-->sfraser

Comment 2

[Simon Fraser [no longer active]]

pink: what do you think?

Comment 3

[Mike Pinkerton (not reading bugmail)]

where does the limit exist? in our shist service or in the chimera ui?

Comment 4

[Andrew Pimlott]

I run into this limit from time to time (which seems to be 50 entries on my
Debian 1.6).  I swear that in older versions of mozilla, there was a pref in the
UI to change this limit.  I also thought I could change it with
browser.sessionhistory.max_entries, but this doesn't seem to have any effect.  I
can still go back only 50 pages.

Moreover, 50 is a ridiculously low limit.  It would probably be sufficient to
increase the limit to 1000 or so without making it a preference.

Comment 5

[zug_treno]

(In reply to comment #4)
> I swear that in older versions of mozilla, there was a pref in the
> UI to change this limit.  I also thought I could change it with
> browser.sessionhistory.max_entries, but this doesn't seem to have any effect.  I
> can still go back only 50 pages.

See bug 197466.

Comment 6

[Samuel Sidler (old account; do not CC)]

Is this a history issue or just a pref that needs to be acknowledged/created?

Comment 7

[Simon Fraser [no longer active]]

The Go menu has global history in it now, with as many items as you have.

Comment 8

[Mike Pinkerton (not reading bugmail)]

in a nightly from the 15th, i get nothing in the go menu on tiger. did you
address that issue with this patch, or are you still relying on the old callback
hack?

Comment 9

[Simon Fraser [no longer active]]

Hrm, the Go menu doesn't rely on any "callback hack". It just overrides [NSMenu
update]. Maybe this is no longer called on Tiger?

Comment 10

[Mike Pinkerton (not reading bugmail)]

that's what i meant (couldn't remember the routine name). update no longer is
called on tiger.

Comment 11

[Paul Borokhov (lensovet)]

Bahhhhh it would be nice if there was a pref to turn off/control the new
behavior, because the Go menu now takes considerably longer to open (i.e. after
you click on it); and realisticly, do we need all those days to be listed there
(especially an entry like More than a week ago)? If you're really looking for
something you might as well open up the history and search there (i.e. using cmd-Y).

Comment 12

[Paul Borokhov (lensovet)]

Sorry for the comment spam, just realized this has been addressed in bug 291414.
just tested it now and realized that it's not only the Go menu lagging. But like
I said, a pref (even if it's just in the .js) is really needed to be able to
control this.