1796958 - [wpt-sync] Sync PR 36614 - Revamp soft navigation tests to use options

Status: RESOLVED FIXED

(Testing :: web-platform-tests, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 36614 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/36614
Details from upstream follow.

Yoav Weiss <[e-mail]> wrote:

Revamp soft navigation tests to use options

This simplifies the tests by having them use an options pattern, reduce
clutter at call sites, and move some common code to utility functions.

Change-Id: If79b4ee5605800e949db83295a6e441d34b8d99f

Reviewed-on: https://chromium-review.googlesource.com/3972419
WPT-Export-Revision: f5e2c696e4ccc3bcc02c23e9e27ec53032e0c8d4

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

PR 36614 applied with additional changes from upstream: c478d0f4a1c3cd64a35b6f451679365dddbed8f5

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=350ce990ba55ddaf88e572b32d87b0f276d4c222

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 10 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 14 tests and 1 subtests

Status Summary

Firefox

TIMEOUT: 28

Chrome

OK : 12
PASS : 3
FAIL : 9
TIMEOUT: 4

Safari

TIMEOUT: 28

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /soft-navigation-heuristics/back.tentative.html [wpt.fyi]: TIMEOUT (Chrome: OK, Safari: TIMEOUT)
  • Detect simple soft navigation.: TIMEOUT (Chrome: FAIL, Safari: TIMEOUT)
• /soft-navigation-heuristics/dropped-entries.tentative.html [wpt.fyi]: TIMEOUT (Chrome: OK, Safari: TIMEOUT)
  • Detect simple soft navigation.: TIMEOUT (Chrome: PASS, Safari: TIMEOUT)
• /soft-navigation-heuristics/image-lcp-followed-by-image-softnav-lcp.tentative.html [wpt.fyi]: TIMEOUT (Chrome: OK, Safari: TIMEOUT)
  • Detect simple soft navigation.: TIMEOUT (Chrome: PASS, Safari: TIMEOUT)
• /soft-navigation-heuristics/image-lcp-followed-by-text-softnav-lcp.tentative.html [wpt.fyi]: TIMEOUT (Chrome: OK, Safari: TIMEOUT)
  • Detect simple soft navigation.: TIMEOUT (Chrome: FAIL, Safari: TIMEOUT)
• /soft-navigation-heuristics/navigation-api-preventDefault.tentative.html [wpt.fyi]: TIMEOUT (Chrome: OK, Safari: TIMEOUT)
  • Aborted navigate event is not a soft navigation: TIMEOUT (Chrome: PASS, Safari: TIMEOUT)
• /soft-navigation-heuristics/navigation-api-rejected.tentative.html [wpt.fyi]: TIMEOUT (Chrome: TIMEOUT, Safari: TIMEOUT)
  • Test intercepted and rejected navigate event: TIMEOUT (Chrome: TIMEOUT, Safari: TIMEOUT)
• /soft-navigation-heuristics/navigation-api.tentative.html [wpt.fyi]: TIMEOUT (Chrome: TIMEOUT, Safari: TIMEOUT)
  • Test soft navigation with the Navigation API: TIMEOUT (Chrome: TIMEOUT, Safari: TIMEOUT)
• /soft-navigation-heuristics/soft-navigation-detection-main-descendent.tentative.html [wpt.fyi]: TIMEOUT (Chrome: OK, Safari: TIMEOUT)
  • Detect soft navigation adding content to a main descendent.: TIMEOUT (Chrome: FAIL, Safari: TIMEOUT)
• /soft-navigation-heuristics/soft-navigation-detection-non-main.tentative.html [wpt.fyi]: TIMEOUT (Chrome: OK, Safari: TIMEOUT)
  • Detect simple soft navigation.: TIMEOUT (Chrome: FAIL, Safari: TIMEOUT)
• /soft-navigation-heuristics/soft-navigation-detection-web-component-lifecycle.tentative.html [wpt.fyi]: TIMEOUT (Chrome: OK, Safari: TIMEOUT)
  • Detect simple soft navigation.: TIMEOUT (Chrome: FAIL, Safari: TIMEOUT)
• /soft-navigation-heuristics/soft-navigation-detection.tentative.html [wpt.fyi]: TIMEOUT (Chrome: OK, Safari: TIMEOUT)
  • Detect simple soft navigation.: TIMEOUT (Chrome: FAIL, Safari: TIMEOUT)
• /soft-navigation-heuristics/soft-navigation-no-url.tentative.html [wpt.fyi]: TIMEOUT (Chrome: OK, Safari: TIMEOUT)
  • Detect simple soft navigation.: TIMEOUT (Chrome: FAIL, Safari: TIMEOUT)
• /soft-navigation-heuristics/text-lcp-followed-by-image-softnav-lcp.tentative.html [wpt.fyi]: TIMEOUT (Chrome: OK, Safari: TIMEOUT)
  • Detect simple soft navigation.: TIMEOUT (Chrome: FAIL, Safari: TIMEOUT)
• /soft-navigation-heuristics/text-lcp-followed-by-text-softnav-lcp.tentative.html [wpt.fyi]: TIMEOUT (Chrome: OK, Safari: TIMEOUT)
  • Detect simple soft navigation.: TIMEOUT (Chrome: FAIL, Safari: TIMEOUT)

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/695a808db6ea
[wpt PR 36614] - Revamp soft navigation tests to use options, a=testonly
https://hg.mozilla.org/integration/autoland/rev/267061796500
[wpt PR 36614] - Update wpt metadata, a=testonly

Comment 5

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/695a808db6ea
https://hg.mozilla.org/mozilla-central/rev/267061796500