1796972 - confirm stopped working in addons

Status: VERIFIED FIXED

(WebExtensions :: General, defect)

Description

[mprops]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:107.0) Gecko/20100101 Firefox/107.0

Steps to reproduce:

confirm("Are you sure?") stopped working in both addons I tested.

Actual results:

It freezes as if the confirm is shown but nothing is shown.

Expected results:

The dialog should have appeared.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Toolkit::Add-ons Manager' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[Tomislav Jovanovic :zombie]

Can you provide an example extensions and exact steps to reproduce?

Comment 3

[mprops]

It happens on this one for example: https://addons.mozilla.org/en-US/firefox/addon/grasshopper-urls/

The Clean button closes all non-pinned tabs. But clicking on it just freezes the UI.

It should show a confirm.

(It only shows the confirm when there are non-pinned tabs to close).

// Confirm tab close
App.confirm_tabs_close = function (tabs) {
  if (tabs.length === 0) {
    return
  }

  let num_tabs = 0

  for (let tab of tabs) {
    if (tab.url !== "about:newtab") {
      num_tabs += 1
    }
  }

  if (num_tabs > 0) {
    let s = App.plural(num_tabs, "tab", "tabs")

    if (confirm(`Close ${s}?`)) {
      for (let tab of tabs) {
        App.close_tab(tab)
      }
    }
  } else {
    for (let tab of tabs) {
      App.close_tab(tab)
    }
  }
}

Comment 4

[mprops]

(It only shows the confirm when there are non-pinned tabs to close).

I mean it's supposed to show it. But it doesn't.

Comment 5

[Alex Cornestean]

Hello,

I reproduced the issue on the latest Nightly (108.0a1/20221024212806) and Beta (107.0b4/20221023190001) under Windows 10 x64 and Ubuntu 16.04 LTS. The issue does not occur on the latest Release (106.0.1/20221019185550)

As described, when clicking the “Clean” button in the extension pop-up, the extension UI freezes and the confirmation prompt is not displayed.

Mozregression identified the regressor as https://bugzilla.mozilla.org/show_bug.cgi?id=1791972

2022-10-25T09:39:50.616000: DEBUG : Found commit message:
Bug 1791972 - Simplify dialog stack and rdm styles. r=Gijs,devtools-reviewers,jdescottes

Differential Revision: https://phabricator.services.mozilla.com/D157912

Pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=407bcfc6b8e579e13b969fe742bd913b5e2657f6&tochange=fcfa744811794944c06c9e3890a4e17edf9d04bb

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1791972

:emilio, since you are the author of the regressor, bug 1791972, could you take a look? Also, could you set the severity field?

For more information, please visit auto_nag documentation.

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

The bug is marked as tracked for firefox107 (beta). However, the bug still isn't assigned.

:mixedpuppy, could you please find an assignee for this tracked bug? Given that it is a regression and we know the cause, we could also simply backout the regressor. If you disagree with the tracking decision, please talk with the release managers.

For more information, please visit auto_nag documentation.

Comment 8

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1796972 - Unify some extensions css. r=dao,Gijs

This doesn't change behavior.

Comment 9

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1796972 - Fix popup container for webextension popups. r=Gijs,dao

Depends on D160224

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7b4f5050dfff
Unify some extensions css. r=Gijs
https://hg.mozilla.org/integration/autoland/rev/822c98962397
Fix popup container for webextension popups. r=Gijs

Comment 11

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/7b4f5050dfff
https://hg.mozilla.org/mozilla-central/rev/822c98962397

Comment 13

[Alex Cornestean]

Verified as fixed on the latest Nightly (108.0a1/20221026034746) under Windows 10 x64 and Ubuntu 16.04 LTS.

When clicking the “Clean” button in the extension pop-up, the extension UI no longer freezes and the confirmation prompt is properly displayed, confirming the fix.

For further details, see the attached screenshot.

Comment 14

[Alex Cornestean]

Attachment: 2022-10-26_14h25_00.png

Comment 15

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:emilio, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox107 to wontfix.

For more information, please visit auto_nag documentation.

Comment 16

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 9300138 [details]
Bug 1796972 - Fix popup container for webextension popups. r=Gijs,dao

Beta/Release Uplift Approval Request

• User impact if declined: comment 0
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: comment 13/14
• List of other uplifts needed: none
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Relatively straight-forward cleanup+fix.
• String changes made/needed: none
• Is Android affected?: No

Comment 17

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 9300137 [details]
Bug 1796972 - Unify some extensions css. r=dao,Gijs

.

Comment 18

[Donal Meehan [:dmeehan]]

Comment on attachment 9300137 [details]
Bug 1796972 - Unify some extensions css. r=dao,Gijs

Approved for 107.0b6.

Comment 19

[Donal Meehan [:dmeehan]]

Comment on attachment 9300138 [details]
Bug 1796972 - Fix popup container for webextension popups. r=Gijs,dao

Approved for 107.0b6.

Comment 20

[Donal Meehan [:dmeehan]]

https://hg.mozilla.org/releases/mozilla-beta/rev/167b37720de9
https://hg.mozilla.org/releases/mozilla-beta/rev/a3b65cfe0bc7

Comment 21

[Alex Cornestean]

Verified as fixed on the latest Beta (107.0b6/20221027185833). Tested on Windows 10 x64 and Ubuntu 16.04 LTS.

When clicking the “Clean” button in the extension pop-up, the extension UI does not freeze and the confirmation prompt is properly displayed, confirming the fix.

For further details, see the attached screenshot.

Comment 22

[Alex Cornestean]

Attachment: 2022-10-28_08h58_04.png