1797050 - Add `max_manifest_version: 2` to manifest `applications` key

Status: RESOLVED FIXED

(WebExtensions :: General, task, P2)

Description

[William Durand [:willdurand]]

We want to get rid of the manifest applications key eventually and exclusively use browser_specific_settings because applications and bss are kinda interchangeable but not always and it is confusing.

We can "forbid" this key in MV3+ so let's update our schema to reflect that.

Comment 1

[William Durand [:willdurand]]

Attachment: Bug 1797050 - Part 1 - Use `browser_specific_settings` instead of `applications` in existing `devtools/` tests. r?rpl!

We want to encourage extension developers to use browser_specific_settings instead of applications,
which will be unsupported in Manifest Version 3+. This patch prepares the introduction of a new warning
(that is usually converted into an error in the test environment).

Comment 2

[William Durand [:willdurand]]

Attachment: Bug 1797050 - Part 2 - Use `browser_specific_settings` instead of `applications` in existing `browser/components/enterprisepolicies/` tests. r?rpl!

We want to encourage extension developers to use browser_specific_settings instead of applications,
which will be unsupported in Manifest Version 3+. This patch prepares the introduction of a new warning
(that is usually converted into an error in the test environment).

Depends on D160057

Comment 3

[William Durand [:willdurand]]

Attachment: Bug 1797050 - Part 3 - Use `browser_specific_settings` instead of `applications` in existing WebExt tests. r?rpl!

We want to encourage extension developers to use browser_specific_settings instead of applications,
which will be unsupported in Manifest Version 3+. This patch prepares the introduction of a new warning
(that is usually converted into an error in the test environment).

Depends on D160058

Comment 4

[William Durand [:willdurand]]

Attachment: Bug 1797050 - Part 4 - Use `browser_specific_settings` instead of `applications` in remaining tests. r?rpl!

We want to encourage extension developers to use browser_specific_settings instead of applications,
which will be unsupported in Manifest Version 3+. This patch prepares the introduction of a new warning
(that is usually converted into an error in the test environment).

Depends on D160059

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7036cc520089
Part 1 - Use `browser_specific_settings` instead of `applications` in existing `devtools/` tests. r=rpl,nchevobbe

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c506fd9f0483
Part 2 - Use `browser_specific_settings` instead of `applications` in existing `browser/components/enterprisepolicies/` tests. r=rpl,mkaply

Comment 7

[William Durand [:willdurand]]

Attachment: Bug 1797050 - Part 7 - Add `max_manifest_version: 2` to manifest `applications` key. r?rpl!

This patch adds the constraint in our schema and fixes the remaining test cases
either by disabling the extensions.webextensions.warnings-as-errors pref OR
by updating the manifests.

Comment 8

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/7036cc520089
https://hg.mozilla.org/mozilla-central/rev/c506fd9f0483

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/53ce60b1b515
Part 4 - Use `browser_specific_settings` instead of `applications` in remaining tests. r=rpl,application-update-reviewers,bytesized

Comment 10

[Sandor Molnar[:smolnar]]

Backed out for causing browser-chrome failures in browser/components/preferences/tests/browser_extension_controlled.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/25cf6e2ac8e140c1495c021d4c6742773ed2da3f

Push with failures

Failure log

INFO - TEST-UNEXPECTED-FAIL | browser/components/preferences/tests/browser_extension_controlled.js | Uncaught exception in test - startup failed

Comment 11

[William Durand [:willdurand]]

Ha, oops, sorry. I think something in the "Part 3" patch is likely needed for the patch I landed earlier.

Comment 12

[William Durand [:willdurand]]

Attachment: Bug 1797050 - Part 5 - Use `browser_specific_settings` instead of `applications` in android test extensions. r?owlish!

We want to encourage extension developers to use browser_specific_settings instead of applications,
which will be unsupported in Manifest Version 3+. This patch makes sure test extensions won't cause any
issues in the future.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4acd13106ce5
Part 3 - Use `browser_specific_settings` instead of `applications` in existing WebExt tests. r=rpl,geckoview-reviewers,extension-reviewers,owlish
https://hg.mozilla.org/integration/autoland/rev/9dacc517cc5d
Part 4 - Use `browser_specific_settings` instead of `applications` in remaining tests. r=rpl,application-update-reviewers,bytesized
https://hg.mozilla.org/integration/autoland/rev/43b652acc72d
Part 5 - Use `browser_specific_settings` instead of `applications` in android test extensions. r=owlish

Comment 14

[William Durand [:willdurand]]

Attachment: Bug 1797050 - Part 6 - Use `browser_specific_settings` instead of `applications` in test manifests. r?rpl!

We want to encourage extension developers to use browser_specific_settings instead of applications, which will be unsupported in Manifest Version 3+. This patch makes sure test manifests in m-c won't cause any issues in the future.

Depends on D160541

Comment 15

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/4acd13106ce5
https://hg.mozilla.org/mozilla-central/rev/9dacc517cc5d
https://hg.mozilla.org/mozilla-central/rev/43b652acc72d

Comment 16

[William Durand [:willdurand]]

Attachment: Bug 1797050 - Part 8 - Add test coverage for the deprecated manifest.json key "applications". r?rpl!

Depends on D160248

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1f33fbe85896
Part 6 - Use `browser_specific_settings` instead of `applications` in test manifests. r=rpl,perftest-reviewers,sparky

Comment 18

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/1f33fbe85896

Comment 19

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3f828529f7b2
Part 7 - Add `max_manifest_version: 2` to manifest `applications` key. r=rpl

Comment 20

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/3f828529f7b2

Comment 21

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6368b24316b9
Part 8 - Add test coverage for the deprecated manifest.json key "applications". r=rpl

Comment 22

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/6368b24316b9

Comment 23

[rbloor]

We have no documentation for the applications manifest key on MDN or the browser compatibility data. If you follow the link to https://developer.mozilla.org/en-US/Add-ons/WebExtensions/manifest.json/applications the page describing the browser_specific_settings key opens. I did find one reference in the notes on contribution to the web extension examples, which I've removed.

Comment 24

[rbloor]

I've also found and fixed several instances on MDN where applications was used as the link text for links to the browser_specific_settings reference page.

Comment 25

[William Durand [:willdurand]]

Then, I guess we are good here?

Comment 26

[rbloor]

Yes - given your feedback that the applications property is still valid in the update manifest, the one remaining reference to this property across our various websites, on Updating your extension, doesn't need changing.