In the customize toolbar view, the bottom controls disappear when the left-hand pane is narrow (and has many rows) - instead of the left hand pane gaining a vertical scrollbar
Categories
(Firefox :: Toolbars and Customization, defect)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox-esr102 | --- | unaffected |
| firefox106 | --- | unaffected |
| firefox107 | --- | unaffected |
| firefox108 | --- | verified |
People
(Reporter: julienw, Assigned: emilio)
References
(Regressed 1 open bug, Regression)
Details
(Keywords: regression)
Attachments
(2 files)
screenshot
STR:
- Put your firefox window out of fullscreen.
- Enable the customization view (right click on the toolbar, click Customize)
- Size the window with a small height.
=> We can't access the controls anymore (see screenshot).
|
||
Comment 1•2 years ago
|
||
Assuming this is on nightly, I am guessing this is a nightly regression, maybe from bug 1790616 - can you clarify/check if you're seeing this on release/nightly and what the regression window is, if any?
|
Assignee | |
Updated•2 years ago
|
|
Reporter | |
Comment 2•2 years ago
|
||
I tried a few Firefox versions as old as v85 and I see the same issue, so it's not a regression at all. I've seen this when I tried a patch locally and I kept the window small so that this wouldn't obscure some other windows, but I think this can happen if folks have smaller screens than our Full HD+ shiny developer screens.
The height where the issue starts depends on the width (that is it depends on the number of lanes for the icons: if there are more than 4 lanes, then the height limit is bigger, but if there are 3 lanes or less, the limit is always the same and (I think) depends on the overflow menu part.
Hope this helps!
|
|
||
Comment 3•2 years ago
•
|
||
On 85 I can go down to ~460px height before things start being cut off, and the left hand side gets a scrollbar so the number of rows of items doesn't matter, the hardcoded size of the overflow panel on the right does.
On current nightly that doesn't seem to be true anymore (and I see issues much higher heights). So I do think something regressed here.
|
|
||
Updated•2 years ago
|
|
||
Comment 4•2 years ago
|
||
Set release status flags based on info from the regressing bug 1790616
|
|
Assignee | |
Updated•2 years ago
|
|
|
Assignee | |
Comment 5•2 years ago
|
||
There was only a min-height: 0 missing. I also cleaned-up a bit because
flex: 1 is the same as flex: 1 1 auto, and flex attribute (which only
sets -moz-box-flex) is not doing anything because it was inside flex
layout (so legacy properties aren't looked at).
|
||
Updated•2 years ago
|
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/0522898e160d Improve behavior of customize mode in small windows. r=Gijs
|
||
Comment 7•2 years ago
|
||
| bugherder | ||
|
||
Updated•1 year ago
|
|
||
Comment 8•1 year ago
|
||
Reproduced the issue with Firefox 108.0a1 (2022-10-24) on macOS 12 and Windows 10. Sizing the window under a certain threshold does not display a scrollable sidebar used to navigate the elements of the customise page.
The issue is verified fixed with Firefox 109.0a1 (20221117214129) on Windows 10, macOS 12 and Ubuntu 22. The sidebar appears after the window is resized to a small enough size and the elements are scrollable.
Description
•