Closed Bug 1797106 Opened 3 years ago Closed 3 years ago

Search terms won't show in the Urlbar on default SERPs if the default search engine isn't in parseSubmissionMap

Categories

(Firefox :: Address Bar, defect, P3)

defect

Tracking

()

RESOLVED DUPLICATE of bug 1698568

People

(Reporter: jteow, Unassigned)

References

Details

While using the showSearchTerms feature, it is possible for a user to install a search engine that won't be added to parseSubmissionMap because the search_url contains the params needed for the search rather than defining them in a params property like search_url_get_params / searchUrlGetParams.

This will result in Services.search.parseSubmissionURL(uri) not returning a value even if uri was a result of one of the engines located in SearchService.#sortedEngines.

Wasn't bug 1698568 meant to fix this?

Flags: needinfo?(jteow)

Yes, good call. I can't recall why I created Bug 1764612 in the first place when it's so similar to Bug 1698568. It's possible my reasoning is similar to now in that Bug 1698568 is a long discussion about why a test isn't working.

I created this bug as record-keeping to know that this particular part of the feature is not going to work, rather than add a comment in a Bug that is focused on getting a test to pass. But in writing about it, it's best just to close this and make a comment in the original bug.

Status: NEW → RESOLVED
Closed: 3 years ago
Flags: needinfo?(jteow)
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.