1797141 - [wpt-sync] Sync PR 36625 - [GridNG] `are_named_lines_valid ` refactor and test

Status: RESOLVED FIXED

(Core :: Layout: Grid, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 36625 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/36625
Details from upstream follow.

Kurt Catti-Schmidt (SCHMIDT) <[e-mail]> wrote:

[GridNG] are_named_lines_valid refactor and test

Ethan pointed out that we're doing a lot of plumbing
for this parameter that's unnecessary due to the state on
NGGridLineResolver.

I had initially thought this could be removed entirely, since all
of the tests passed without it (see initial commit), but Ethan
also provided a repro that failed without them. So this CL also
adds a test that fails whenare_named_lines_valid is removed
entirely.

Bug: 618969
Change-Id: Iff065a9f4d104ca75942dbe7b3a5c0e2c262c15b

Reviewed-on: https://chromium-review.googlesource.com/3956669
WPT-Export-Revision: 961dcea838788272794e74c47378655702cd44fe

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=eec7485999ea72f1b98b0a3df45dc9cdabbc6e74

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/799844360d98
[wpt PR 36625] - [GridNG] `are_named_lines_valid ` refactor and test, a=testonly

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Test result changes from PR not available.

Comment 4

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/799844360d98