1797163 - handle IAsyncOperations better in windows package manager

Status: RESOLVED FIXED

(Firefox :: Shell Integration, enhancement, P2)

Description

[[e-mail] (:bhearsum)]

Currently, we're basically spinlocking constantly checking the status of the operation waiting for it to complete. nrishel found some docs that provide an example of how to use a callback instead, which we ought to do.

Comment 1

[[e-mail] (:bhearsum)]

Attachment: Bug 1797163: handle IAsyncOperations with callbacks and events instead of spinlocking r?nrishel!

I was able to verify that the callback code runs and completes sucessfully, but I've been able build a version of Nightly that I can upload to the Store to fully verify that campaign IDs are still retrieved. My intention is to verify this in Beta (where we have "published" but non-public builds, and backout or adjust if any follow-up is needed.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e1e7e5337313
handle IAsyncOperations with callbacks and events instead of spinlocking r=nrishel

Comment 3

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/e1e7e5337313

Comment 4

[[e-mail] (:bhearsum)]

Comment on attachment 9300617 [details]
Bug 1797163: handle IAsyncOperations with callbacks and events instead of spinlocking r?nrishel!

Beta/Release Uplift Approval Request

• User impact if declined: Some MSIX users will crash or experience hangs -- this is the #1 crasher & hang for Store builds at the moment.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce: (Not possible to test in Nightly)
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Only affects MSIX builds; has been verified by hand by me.
• String changes made/needed:
• Is Android affected?: No

Comment 5

[Dianna Smith [:diannaS]]

Comment on attachment 9300617 [details]
Bug 1797163: handle IAsyncOperations with callbacks and events instead of spinlocking r?nrishel!

Approved for 108.0b6

Comment 6

[Dianna Smith [:diannaS]]

https://hg.mozilla.org/releases/mozilla-beta/rev/4518877060df