179728 - work offline not unchecked when toggled from status bar

Status: VERIFIED FIXED

(SeaMonkey :: UI Design, defect)

Description

[John Mertic]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.2b) Gecko/20021105
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.2b) Gecko/20021105

When you switch from Work Online to Work Offline and then back to Work Online
using the status bar icon, the check in the file menu next to Work Offline
remains checked

Reproducible: Always

Steps to Reproduce:
From Work Online mode
1. Click on the Work Offline icon in the status bar
2. Click on the same icon ( now used to go back Online )


Actual Results:  
In the File menu, the check next to Work Offline is still there

Expected Results:  
There should be no check next to Work Offline

Comment 1

[Wesha]

CONFIRMED 2002111108
Seems that it's pourely cosmetic issue; clicking the Offline item in the menu
redraws teh statusbar icon properly; and statusbar icon sets internal
online/offline flag properly as well. You can make the checkmarka appear in the
menu by clicking the icon, but not disappear.

Comment 2

[Wesha]

See bug 158976 for more details. It might happen that the checkmark
functionality will be removed at all...

Comment 3

[Jeremy M. Dolan]

linux too

Comment 4

[grylchan]

I believe we are going to back out the check/unchecked
for work on/off line and go back to the old way.
Wesha is correct that bug 158976 is the bug that
landed this feature. When module owners respond to that
bug, than i'll make the appropriate changes to this bug
(invalid if we are going to go back to the old way
or assign the bug if we change our minds and we want
this feature).

Comment 5

[Jo Hermans]

*** Bug 183908 has been marked as a duplicate of this bug. ***

Comment 6

[[e-mail]]

Attachment: Proposed patch

See bug 158976 for an alternative approach.

Comment 7

[(not reading, please use [e-mail] instead)]

re-assigning to neil.

neil, I assume you need r/sr for this.

Comment 8

[(not reading, please use [e-mail] instead)]

Comment on attachment 114006 [details] [diff] [review]
Proposed patch

asking jag to review neils patch (since this is xpfe) and I can sr.

Comment 9

[(not reading, please use [e-mail] instead)]

neil, do you think could sort out all three bugs (this one, bug #80971, and bug
#158976) in 1.4?

Comment 10

[Frederic Bezies]

*** Bug 193655 has been marked as a duplicate of this bug. ***

Comment 11

[grylchan]

*** Bug 195303 has been marked as a duplicate of this bug. ***

Comment 12

[Benedikt Kantus]

*** Bug 195617 has been marked as a duplicate of this bug. ***

Comment 13

[Chris Lyon]

*** Bug 196622 has been marked as a duplicate of this bug. ***

Comment 14

[Kevin Neely]

UA: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.4a) Gecko/20030304

I don't see it mentioned in the comments, but this also happens if you, say, go
offline in mailnews, then go back online in navigator.  The checkmark in the
browser is correct, but the check is still next to 'work offline' in the
mailnews File> dialogue.

Cosmetic, but confusing.

Comment 15

[David Crick]

Confirm comments about various behaviours; also, if you're
offline, click "Get Msgs" in Mail and then click "Go Online"
in the dialog that pops up, this too confuses the indicators.

Basically the various methods and indicators for going/being
on- and offline seem to not be synchronised with eachother.

I've put up with this annoyance since <whenever>, but it would
seem a fairly trivial thing to fix for what is supposed to be
the polished and perfected 1.4 Final, before we head off to
Phoenixland.

Comment 16

[benc]

Lets assign this to a component so it gets QA.

Comment 17

[:deanis74]

Comment on attachment 114006 [details] [diff] [review]
Proposed patch

Short and sweet.  r=me

Comment 18

[[e-mail]]

Comment on attachment 114006 [details] [diff] [review]
Proposed patch

sr hokey-cokey ;-)

Comment 19

[[e-mail]]

Comment on attachment 114006 [details] [diff] [review]
Proposed patch

Cosmetic improvement for people who work offline, no risk to anyone else.

Comment 20

[Asa Dotzler [:asa]]

Comment on attachment 114006 [details] [diff] [review]
Proposed patch

a=asa (on behalf of drivers) for checkin to Mozilla 1.5beta.

Comment 21

[[e-mail]]

Fix checked in.

Comment 22

[Wolfgang Rosenauer [:wolfiR]]

*** Bug 216003 has been marked as a duplicate of this bug. ***

Comment 23

[benc]

If someone else besides paw can verify it, that would be great.

Comment 24

[noririty]

v.

Comment 25

[Peter 'vt100' Schwindt]

*** Bug 229940 has been marked as a duplicate of this bug. ***

Comment 26

[benc]

*** Bug 205553 has been marked as a duplicate of this bug. ***