1797286 - [wpt-sync] Sync PR 36648 - [css-nesting] Serialize declarations in conditional group rules.

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 36648 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/36648
Details from upstream follow.

Steinar H. Gunderson <[e-mail]> wrote:

[css-nesting] Serialize declarations in conditional group rules.

When we have an implicit & {} rule in a conditional group rule
added to hold declarations (since we don't support having declarations
immediately inside such rules), or something that looks very much
like it, remove that & {} and serialize only the declarations.
This is consistent with CSS' usual guideline that we serialize
to the shortest possible form.

In the process, I discovered that we have no spec for serializing
conditional group rules with declarations in them, so I wrote up
one that describes this removal of implicit & {}. This has been
consolidated in a post in https://github.com/w3c/csswg-drafts/issues/7850.

Added a tentative WPT test.

Change-Id: I46aee5ceffcf2b30a6faf3cb51f51eeb02ee67ea

Reviewed-on: https://chromium-review.googlesource.com/3972483
WPT-Export-Revision: 81a6369fcd2e3b98d932105d463a46d88a4e61ef

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

PR 36648 applied with additional changes from upstream: 4eea9bf182441d01a4c91cf7b08d8bdef7a9c38f, 38ddcd38f6da0171075e02792c777485f6d51319, 7c43cc22484a4c6ff65988a9ba0c681739f7903b

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=814ad377c39a4bc1fbe82dfc8bc2b42b84431411

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 10 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 3 tests and 5 subtests

Status Summary

Firefox

OK : 3
FAIL: 16

Chrome

OK : 3
FAIL: 16

Safari

OK : 3
FAIL: 16

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /css/css-nesting/cssom.html [wpt.fyi]
  • Simple CSSOM manipulation of subrules: FAIL (Chrome: FAIL, Safari: FAIL)
  • Simple CSSOM manipulation of subrules 1: FAIL (Chrome: FAIL, Safari: FAIL)
  • Simple CSSOM manipulation of subrules 2: FAIL (Chrome: FAIL, Safari: FAIL)
  • Simple CSSOM manipulation of subrules 3: FAIL (Chrome: FAIL, Safari: FAIL)
  • Simple CSSOM manipulation of subrules 4: FAIL (Chrome: FAIL, Safari: FAIL)
  • Simple CSSOM manipulation of subrules 5: FAIL (Chrome: FAIL, Safari: FAIL)
  • Simple CSSOM manipulation of subrules 6: FAIL (Chrome: FAIL, Safari: FAIL)
  • Simple CSSOM manipulation of subrules 7: FAIL (Chrome: FAIL, Safari: FAIL)
  • Simple CSSOM manipulation of subrules 8: FAIL (Chrome: FAIL, Safari: FAIL)
• /css/css-nesting/invalid-inner-rules.html [wpt.fyi]
  • Simple CSSOM manipulation of subrules: FAIL (Chrome: FAIL, Safari: FAIL)
  • Simple CSSOM manipulation of subrules 1: FAIL (Chrome: FAIL, Safari: FAIL)
• /css/css-nesting/serialize-group-rules-with-decls.tentative.html [wpt.fyi]
  • Serialization of declarations in group rules: FAIL (Chrome: FAIL, Safari: FAIL)
  • Serialization of declarations in group rules 1: FAIL (Chrome: FAIL, Safari: FAIL)
  • Serialization of declarations in group rules 2: FAIL (Chrome: FAIL, Safari: FAIL)
  • Serialization of declarations in group rules 3: FAIL (Chrome: FAIL, Safari: FAIL)
  • Serialization of declarations in group rules 4: FAIL (Chrome: FAIL, Safari: FAIL)

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2a127f8c1e6c
[wpt PR 36648] - [css-nesting] Serialize declarations in conditional group rules., a=testonly
https://hg.mozilla.org/integration/autoland/rev/6a366e2e3a22
[wpt PR 36648] - Update wpt metadata, a=testonly

Comment 5

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/2a127f8c1e6c
https://hg.mozilla.org/mozilla-central/rev/6a366e2e3a22