1797347 - Only enable OOP WebGL on Android on Nightly

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, task)

Description

[Jamie Nicol [:jnicol]]

It's causing bug 1794237. Rather than disable it altogether, let's just hold it back to nightly. Hopefully that way we'll get a bug report with a URL to help us actually fix the crash.

Comment 1

[Jamie Nicol [:jnicol]]

Attachment: Bug 1797347 - Limit OOP webgl to nightly-only on android. r?#gfx-reviewers

It's causing bug 1794237. Rather than disable it altogether, let's
just hold it back to nightly. Hopefully that way we'll eventually get
a bug report with a URL to help us actually fix the crash.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/032a7ecf82a8
Limit OOP webgl to nightly-only on android. r=gfx-reviewers,lsalzman

Comment 3

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/032a7ecf82a8

Comment 4

[Jamie Nicol [:jnicol]]

Comment on attachment 9300182 [details]
Bug 1797347 - Limit OOP webgl to nightly-only on android. r?#gfx-reviewers

Beta/Release Uplift Approval Request

• User impact if declined: Crashes - bug 1794237
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Disables feature that was only enabled last cycle
• String changes made/needed:
• Is Android affected?: Yes

Comment 5

[Donal Meehan [:dmeehan]]

Comment on attachment 9300182 [details]
Bug 1797347 - Limit OOP webgl to nightly-only on android. r?#gfx-reviewers

Approved for Desktop 107.0b6 and Fenix/Focus 107.0b4

Comment 6

[Donal Meehan [:dmeehan]]

https://hg.mozilla.org/releases/mozilla-beta/rev/45edbc67f107

Comment 7

[Jamie Nicol [:jnicol]]

Attachment: Bug 1797347 - Actually disable OOP webgl on Android on non-nightly. r?lsalzman

This was accidentally left enabled by the previous patch, since
XP_LINUX is true on Android. We must therefore use

defined(XP_LINUX) && !defined(ANDROID)

instead, as we did prior to enabling OOP webgl on Android in the first
place.

Comment 8

[Jamie Nicol [:jnicol]]

Comment on attachment 9301401 [details]
Bug 1797347 - Actually disable OOP webgl on Android on non-nightly. r?lsalzman

Beta/Release Uplift Approval Request

• User impact if declined: Out of process webgl will be enabled on 107, which causes crashes in bug 1794237
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Fixes a bug with the previous attempt to disable this pref
• String changes made/needed:
• Is Android affected?: Yes

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5b0ba0abbfa5
Actually disable OOP webgl on Android on non-nightly. r=lsalzman

Comment 10

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/5b0ba0abbfa5

Comment 11

[Donal Meehan [:dmeehan]]

Comment on attachment 9301401 [details]
Bug 1797347 - Actually disable OOP webgl on Android on non-nightly. r?lsalzman

Approved for Desktop 107.0b9 and Fenix/Focus 107.0b6

Comment 12

[Donal Meehan [:dmeehan]]

https://hg.mozilla.org/releases/mozilla-beta/rev/728d2e95159c