Open Bug 1797542 Opened 2 years ago Updated 2 years ago

Cleanup use of GetFaviconLinkForIcon helpers

Categories

(Toolkit :: Places, task, P5)

Product:
Toolkit
Component:
Places
Type:
task

Tracking

()

People

(Reporter: sclements, Unassigned)

References

Details

(Whiteboard: [snt-scrubbed][places-tech-debt])

This came up during a code review, that we should either remove PlacesUIUtils.getImageURL and instead modify https://searchfox.org/mozilla-central/source/toolkit/components/places/nsFaviconService.cpp#654 changing it to return moz-anno:favicon only for http* protocols, so we can directly use GetFaviconLinkForIcon.

Alternatively, we could remove GetFaviconLinkForIcon and keep PlacesUIUtils.getImageURL (but change the name to reflect what its actually doing) and use that for all the JS consumers that currently use GetFaviconLinkForIcon .

Thank you for filing this, I suspect the js way will be better to avoid crossing xpcom.

Severity: -- → S4
Component: General → Places
Priority: -- → P5
Product: Firefox → Toolkit
Summary: Cleanup use of favicon helpers → Cleanup use of GetFaviconLinkForIcon helpers
Whiteboard: [snt-scrubbed][places-tech-debt]
You need to log in before you can comment on or make changes to this bug.