Closed Bug 1797577 Opened 2 years ago Closed 1 year ago

[3.3] Create toggle option in the toolbar that allow a site to be excluded from cookie banner handling in Fenix

Categories

(Fenix :: Privacy, task, P2)

All
Android

Tracking

(firefox109 verified)

VERIFIED FIXED
Tracking Status
firefox109 --- verified

People

(Reporter: amejia, Assigned: amejia)

References

(Blocks 1 open bug)

Details

(Whiteboard: [cookie-banner] [geckoview:m110])

Attachments

(1 file)

Similar to what we do with tracking protection, user swill have an option in the doorhander where they will able to add the current site to an exception list.

Depends on: 1797581
Summary: Create toggle option in the toolbar that allow a site to be excluded from cookie banner handling in Fenix → [4.2] Create toggle option in the toolbar that allow a site to be excluded from cookie banner handling in Fenix
Summary: [4.2] Create toggle option in the toolbar that allow a site to be excluded from cookie banner handling in Fenix → [4.2.1] Create toggle option in the toolbar that allow a site to be excluded from cookie banner handling in Fenix
Summary: [4.2.1] Create toggle option in the toolbar that allow a site to be excluded from cookie banner handling in Fenix → [4.3.1] Create toggle option in the toolbar that allow a site to be excluded from cookie banner handling in Fenix

Acceptance criteria is here
Mock up

Depends on: 1797605
No longer depends on: 1797581
Summary: [4.3.1] Create toggle option in the toolbar that allow a site to be excluded from cookie banner handling in Fenix → [3.3.1] Create toggle option in the toolbar that allow a site to be excluded from cookie banner handling in Fenix
Depends on: 1797609
No longer depends on: 1797605
Summary: [3.3.1] Create toggle option in the toolbar that allow a site to be excluded from cookie banner handling in Fenix → [3.3] Create toggle option in the toolbar that allow a site to be excluded from cookie banner handling in Fenix
Severity: -- → N/A
Type: enhancement → task
Depends on: 1797605
No longer depends on: 1797609
Priority: -- → P2
Whiteboard: [cookie-banner] [geckoview:m108] → [cookie-banner] [geckoview:m108] [geckoview:m109]
Assignee: nobody → amejiamarmol
Whiteboard: [cookie-banner] [geckoview:m108] [geckoview:m109] → [cookie-banner] [geckoview:m110]

This functionality just landed in main, it should be available in the upcoming nightly updates.

QA info:

Mockups

Test toggle is shown:

With a fresh install
Go to Settings -> Cookie Banner Reduction -> Turn on the toggle.
Go to www.youtube.com
Tap on the lock icon

Expected
The cookie banner panel should be visible, as the global setting is on by default.

Test toggle is hidden:

With a fresh install.
Go to www.youtube.com
Tap on the lock icon

Expected
The cookie banner panel shouldn't be visible, as the global setting is off by default.

Test the toggle

With a fresh install
Go to Settings -> Cookie Banner Reduction -> Turn on the toggle
Go to www.youtube.com
Tap on the lock icon
Tap on cookie banner reduction
The cookie banner section should be visible, as we turned the global setting on
Tap on cookie banner reduction
*The switch should be ON
Go to about:config
Find cookiebanners.service.mode and update it to 1
Go to www.amazon.de
The amazon.de cookie banner should be visible, as this banner is only block on cookiebanners.service.mode=2.
Tap on the lock icon
Tap on the cookie banner reduction section, the toggle it OFF.
The cookie banner should be visible, as this banner is only block on cookiebanners.service.mode=2.
Go to about:config
Find cookiebanners.service.mode and update it to 2
Go to www.amazon.de
The amazon.de cookie banner should be visible, as it's ignored because we toggled OFF for this site.
Tap on the lock icon
Tap on the cookie banner reduction section, the toggle it ON.
The amazon.de cookie banner should be gone🎉, as we remove the exception

Telemetry events

cookie_banners.exception_added: When users turn ON the toggle on the toolbar.
cookie_banners.exception_removed: When users turn OFF the toggle on the toolbar.
cookie_banners.visited_panel: When users click on cookie banner reduce in the toolbar.

Flags: qe-verify?

Hello!
We've tested this and had the following outcome:

  • The Cookie Banner Reduction is present in the ETP Panel.
  • The status of the Cookie Banner Reduction is correctly updated.
  • The user is able to change the status of the Cookie Banner Reduction for the site he/she's currently browsing.
  • The Cookie Banner Reduction settings are saved for exceptions even after Firefox' restart.

Also tested the telemetry and got the following events:
{
"timestamp": 24365,
"category": "cookie_banners",
"name": "exception_added"
},
{
"timestamp": 32621,
"category": "cookie_banners",
"name": "visited_panel"
},
{
"timestamp": 33782,
"category": "cookie_banners",
"name": "exception_removed"
}
Devices used for testing: Google Pixel 6 (Android 13), Oppo Find X3 Neo (Android 11), Samsung Galaxy S22 Ultra (Android 13), Huawei Mediapad M3 Lite 10 (Android 7). Tested on the Latest Nightly from 12th of December 2022 (109.0a1).

Thanks!

Flags: qe-verify?

@Arturo, can this issue be closed?

Thanks @Andrei , yes🎉!

Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: