1797578 - [3.4] Create toggle option in the toolbar that allow a site to be excluded from cookie banner handling in Focus

Status: VERIFIED FIXED

(Focus :: General, task, P2)

Description

[Arturo Mejia [:amejia]]

Similar to what we do with tracking protection, user swill have an option in the doorhander where they will able to add the current site to an exception list.

Comment 1

[Iorga Gabriel]

Cookie banner panel part
1)If the CookieBannerHandleMode is reject_all or reject_or_accept_all, I show the toggle. If the site has no exception, the toggle will be true.

https://user-images.githubusercontent.com/8118371/202170298-fb073c37-f876-4a7a-91d5-ebb0cbce2158.png

2)If the CookieBannerHandleMode is disabled, the toggle and all the cookie banner section will be hidden.

https://user-images.githubusercontent.com/8118371/202171088-d413a06f-ff5e-4b60-bf33-6c9fcfb2f548.jpg

3)If the user sets the toggle to false, I'm going to add the site to the exception list with the value MODE_DISABLED.

https://user-images.githubusercontent.com/8118371/202171869-87dec253-a4d3-441c-991e-014b7d434721.png

4)If the site doesn't have a cookie banner and CookieBannerHandleMode is reject_all, or accept_all, I will show the section but not the toggle.

https://user-images.githubusercontent.com/8118371/202172562-08319d20-9384-428c-be70-44b939fbfffb.png

Comment 2

[Iorga Gabriel]

I landed the pr https://github.com/mozilla-mobile/focus-android/pull/8124 the fourth case is not supported yet. If the user exits and enters the app again, the exception is not persistent.

Comment 3

[Iorga Gabriel]

Telemetry events
cookie_banner.exception_added: When users turn ON the toggle on the toolbar.
cookie_banner.exception_removed: When users turn OFF the toggle on the toolbar.
cookie_banner.visited_panel: When users click on cookie banner reduce in the toolbar.

Comment 4

[jguerrero]

(In reply to Iorga Gabriel from comment #1)

Cookie banner panel part
1)If the CookieBannerHandleMode is reject_all or reject_or_accept_all, I show the toggle. If the site has no exception, the toggle will be true.

https://user-images.githubusercontent.com/8118371/202170298-fb073c37-f876-4a7a-91d5-ebb0cbce2158.png

2)If the CookieBannerHandleMode is disabled, the toggle and all the cookie banner section will be hidden.

https://user-images.githubusercontent.com/8118371/202171088-d413a06f-ff5e-4b60-bf33-6c9fcfb2f548.jpg

3)If the user sets the toggle to false, I'm going to add the site to the exception list with the value MODE_DISABLED.

https://user-images.githubusercontent.com/8118371/202171869-87dec253-a4d3-441c-991e-014b7d434721.png

4)If the site doesn't have a cookie banner and CookieBannerHandleMode is reject_all, or accept_all, I will show the section but not the toggle.

https://user-images.githubusercontent.com/8118371/202172562-08319d20-9384-428c-be70-44b939fbfffb.png

Hi Gabriel,

Few comments on UI/UX:

1. Minor, but the font size of 'Cookie Banner Reduction' looks larger than the other texts
2. In scenarios 3 and 4, the icon should be the disabled cookie icon (see here for reference: https://www.figma.com/file/o3TMGgSnpGNvA9GXb7FUu6/Auto-Cookie-Banners-(Focus)?node-id=603%3A17020&t=ZtIsvvfQUY4emBfs-1)
3. This is currently the old toggle version - are we updating these to the versions with chevrons in the next iteration?

Comment 5

[Iorga Gabriel]

Hi @jguerrero this screenshots are from Figma's first version. If you want to see how it looks in the app, please install it, or I attached some screenshots in the pr https://github.com/mozilla-mobile/focus-android/pull/8124.

Comment 7

[BMO Automation]

Attachment: [mozilla-mobile/firefox-android] For Bug 1797578 Added the case when the site doesn't have a cookie banner (#389)

Comment 8

[BMO Automation]

Authored by https://github.com/iorgamgabriel
https://github.com/mozilla-mobile/firefox-android/commit/c424b92415112b46d18a619e1eee1f5a591a1da5
Bug 1797578 - Added the case when the site doesn't have a cookie banner

Comment 9

[miralobontiu]

Verified that everything works as expected on a debug build from 3/13.
The CBR toggle from the toolbar's menu can be turned OFF, and Focus is no longer blocking the cookie banners prompt of the website.
The CBR toggle from the toolbar's menu can be turned ON again, and Focus blocks the cookie banners prompt of the website.

I'll remove the qe-verify+ label, and mark this bug as Verified.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b1aef6f21ccd
[focus] For #1797578 - Create toggle option in the toolbar that allow a site to be excluded from cookie banner handling in Focus