Closed Bug 1797787 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 36690 - Honor decisions to repeat table sections when column-balancing.

Categories

(Core :: Layout, task, P4)

Product:
Core
Component:
Layout
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
108 Branch
Tracking Flags:
Tracking Status
firefox108 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 36690 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/36690
Details from upstream follow.

Morten Stenshorne <mstensho@chromium.org> wrote:

Honor decisions to repeat table sections when column-balancing.

This is a follow-up to CL:3986446

Once we have decided to repeat a section, we must keep on doing that for
all table fragments. This also includes the "initial" column balancing
pass that might take place for each fragment inside a fragmented
multicol container.

Otherwise we're going to mess up the results stored in the LayoutBox.
What would happen is that when performing the initial column balancing
pass for the second inner multicol fragment, we'd start laying out the
table row in the header from scratch, since no incoming break token was
passed. A row inside a repeated section isn't meant to be resumed, or
laid out at all more than once. The fragment repeater is in charge of
cloning and finalizing things correctly when we have reached the last
table box fragment.

Bug: 1378657, 1375179
Change-Id: I6e2f2e1827fe8ca61551ee00aa855776f405af1e
Reviewed-on: https://chromium-review.googlesource.com/3985812
WPT-Export-Revision: 0e80ecc105d3fccd398f629944b94aa99b949fd5

Component: web-platform-tests → Layout
Product: Testing → Core

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

FAIL: 1

Chrome

FAIL: 1

Safari

FAIL: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a3549b94bfe6 [wpt PR 36690] - Honor decisions to repeat table sections when column-balancing., a=testonly https://hg.mozilla.org/integration/autoland/rev/5c40cf49f913 [wpt PR 36690] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/a3549b94bfe6
https://hg.mozilla.org/mozilla-central/rev/5c40cf49f913

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox108: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 108 Branch
You need to log in before you can comment on or make changes to this bug.