1797797 - [wpt-sync] Sync PR 36692 - [css-nesting] Move towards syntax proposal 3.

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 36692 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/36692
Details from upstream follow.

Steinar H. Gunderson <[e-mail]> wrote:

[css-nesting] Move towards syntax proposal 3.

Remove the demand to have @nest, and really all traces of it;
everything that's not an ident or at-rule will now start
parsing a selector. We support both implicit insertion of
descendant selectors, and parsing of relative nested selectors.

Serialization is currently somewhat unspecified. Error recovery
(which seems to be somewhat special for these selectors)
is not fully tested, and may be wrong. We also still do not
forbid properties after selectors.

Change-Id: I097c4bb8fb1a93222820d84510057224173a83bc

Reviewed-on: https://chromium-review.googlesource.com/3987945
WPT-Export-Revision: 1b59ee5fab123615aa524bc8eceab10ec0911809

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

PR 36692 applied with additional changes from upstream: 4eea9bf182441d01a4c91cf7b08d8bdef7a9c38f

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=8bda286b1229336626b7c5a11b02063459efa11c

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 10 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 6 tests

Status Summary

Firefox

OK : 2
FAIL: 14[Gecko-android-em-7.0-x86_64-qr-debug-isolated-process-geckoview] 18[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt, GitHub]

Chrome

OK : 2
PASS: 11
FAIL: 7

Safari

OK : 2
FAIL: 18

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /css/css-nesting/invalidation-003.html [wpt.fyi]
  • CSS Selectors nested invalidation with :has(): FAIL (Chrome: FAIL, Safari: FAIL)
• /css/css-nesting/parsing.html [wpt.fyi]
  • .foo {
    & { color: green; }
    }: FAIL (Chrome: PASS, Safari: FAIL)
  • .foo {
    &.bar { color: green; }
    }: FAIL (Chrome: PASS, Safari: FAIL)
  • .foo {
    & .bar { color: green; }
    }: FAIL (Chrome: PASS, Safari: FAIL)
  • .foo {
    & > .bar { color: green; }
    }: FAIL (Chrome: PASS, Safari: FAIL)
  • .foo {
    &:is(.bar, &.baz) { color: green; }
    }: FAIL (Chrome: PASS, Safari: FAIL)
  • .foo {
    .bar& { color: green; }
    }: FAIL (Chrome: FAIL, Safari: FAIL)
  • .foo {
    .bar & { color: green; }
    }: FAIL (Chrome: FAIL, Safari: FAIL)
  • .foo {
    .bar > & { color: green; }
    }: FAIL (Chrome: FAIL, Safari: FAIL)
  • .foo, .bar {
    & + .baz, &.qux { color: green; }
    }: FAIL (Chrome: PASS, Safari: FAIL)
  • .foo {
    & .bar & .baz & .qux { color: green; }
    }: FAIL (Chrome: PASS, Safari: FAIL)
  • .foo {
    @media (min-width: 50px) {
    & { color: green; }
    }
    }: FAIL (Chrome: FAIL, Safari: FAIL)
  • .foo {
    @media (min-width: 50px) { color: green; }
    }: FAIL (Chrome: PASS, Safari: FAIL)
  • main {
    & > section, & > article {
    & > header { color: green; }
    }
    }: FAIL (Chrome: PASS, Safari: FAIL)
• /css/css-nesting/conditional-properties.html [wpt.fyi]: FAIL (Chrome: PASS, Safari: FAIL)
• /css/css-nesting/conditional-rules.html [wpt.fyi]: FAIL (Chrome: PASS, Safari: FAIL)
• /css/css-nesting/implicit-nesting.html [wpt.fyi]: FAIL (Chrome: FAIL, Safari: FAIL)
• /css/css-nesting/nesting-basic.html [wpt.fyi]: FAIL (Chrome: FAIL, Safari: FAIL)

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0274ddacf738
[wpt PR 36692] - [css-nesting] Move towards syntax proposal 3., a=testonly
https://hg.mozilla.org/integration/autoland/rev/e9799e4fc5a4
[wpt PR 36692] - Update wpt metadata, a=testonly

Comment 5

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/0274ddacf738
https://hg.mozilla.org/mozilla-central/rev/e9799e4fc5a4