Closed Bug 1797899 Opened 2 years ago Closed 1 year ago

Rename ExperimentManager.getAllActive() / getAllRollouts()

Categories

(Firefox :: Nimbus Desktop Client, task, P4)

task

Tracking

()

RESOLVED FIXED
112 Branch
Tracking Status
firefox112 --- fixed

People

(Reporter: barret, Assigned: fanie, Mentored, NeedInfo)

Details

(Keywords: good-first-bug)

Attachments

(1 file)

The names imply they should get all active enrollments vs all rollouts, but really these functions return all active experiments and all active rollouts, respectively.

I started to work on this.

How can I assign myself this ticket?

Assignee: nobody → fanie
Status: NEW → ASSIGNED

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:fanie, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit auto_nag documentation.

Flags: needinfo?(fanie)
Flags: needinfo?(brennie)

No futher work I want to do here, waiting for someone who can land this for me. Waiting for chrismas holidays to end.

Flags: needinfo?(fanie)
Pushed by brennie@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ad6f657ccb60
Rename getAllActive and getAllRollouts functions. r=barret

Backed out for causing bc failures

Flags: needinfo?(fanie)
Pushed by archaeopteryx@coole-files.de:
https://hg.mozilla.org/integration/autoland/rev/8b3b3c83025d
Rename getAllActive and getAllRollouts functions. r=barret

Backed out changeset 8b3b3c83025d (Bug 1797899) for bc failures on browser_AddonStudies.js.
Backout link
Push with failures
Failure Log

Pushed by brennie@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/831d3d2483c5
Rename getAllActive and getAllRollouts functions. r=barret
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 112 Branch
Flags: needinfo?(brennie)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: