1797965 - Google search engine ( which was removed via the SearchEngines policy) is automatically re-added after browser restart if restoring the default search engines

Status: VERIFIED FIXED

(Firefox :: Enterprise Policies, defect, P5)

Description

[Emil Ghitta, QA [:emilghitta]]

Notes

• This is an ESR-only policy (reproducible only in ESR and Nightly builds).

Found in

• 108.0a1

Affected versions

• Firefox 108.0a1
• Firefox 102.4.0esr

Tested platforms

• Affected platforms: Windows 10 64bit, macOS 11 & Ubuntu 22.04

Preconditions
Add the following code inside the policies.json file:

{
"policies": {
"SearchEngines": {
"Remove": ["Google"]
}
}
}

Steps to reproduce

• Steps are similar to Bug 1499095:

1. Launch Firefox.
2. Access the about:preferences#search page.
3. Click the "Restore Default Search Engines" button.
4. Restart Firefox.

Expected result

• "Google" search engine is no displayed.

Actual result

• "Google" search engine is displayed

Regression range

• I don't thinks that this is a regression.

Comment 1

[Mike Kaply [:mkaply]]

Attachment: Bug 1797965 - Don't restore Google engine if hidden. r?standard8

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a504a8c33625
Don't restore Google engine if hidden. r=Standard8

Comment 3

[Sandor Molnar[:smolnar]]

Backed out for causing xpc failures in browser/components/enterprisepolicies/tests/xpcshell/test_policy_search_engine.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/0cebfb9103a56430744c2b7c3dade664b9092a80

Push with failures

Failure log

TEST-UNEXPECTED-FAIL | browser/components/enterprisepolicies/tests/xpcshell/test_policy_search_engine.js | xpcshell return code: 0

Comment 4

[Mike Kaply [:mkaply]]

Try run:

https://treeherder.mozilla.org/jobs?repo=try&revision=51a210beb5b7c2421665507aaf53a0b42c90c90b

linting error fixed.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d7eb7b1e5ce6
Don't restore Google engine if hidden. r=Standard8

Comment 6

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/d7eb7b1e5ce6

Comment 7

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Reproducible on a 2023-01-25 Nightly build on Ubuntu 22.
Verified as fixed on Nightly 112.0a1(build ID: 20230302045723) on Ubuntu 22, macOS 12, Windows 11.
Google is no longer displayed in the Search Engines list after a browser restart.