1797992 - [wpt-sync] Sync PR 36717 - Align cssRGB.html with the specification and fix mistake

Status: RESOLVED FIXED

(Testing :: web-platform-tests, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 36717 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/36717
Details from upstream follow.

Chris Dumez <[e-mail]> wrote:

Align cssRGB.html with the specification and fix mistake

Per the specification, the parameters are passed to:

• https://drafts.css-houdini.org/css-typed-om-1/#rectify-a-csscolorrgbcomp
• https://drafts.css-houdini.org/css-typed-om-1/#rectify-a-csscolorpercent

These throw a SyntaxError in case of issue but the test was incorrectly expecting a TypeError instead.

Also, one of the loops was incorrectly using value instead of color. value was undefined and we were thus not testing what we intended to test. We just kept calling the functions with undefined instead of the test values.

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=a9add840a3709db5c3a95373b61e05409a7cbb96

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 53 subtests

Status Summary

Firefox

ERROR: 1

Chrome

OK : 1
PASS : 31
FAIL : 22

Safari

ERROR: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /css/css-typed-om/stylevalue-subclasses/cssRGB.html [wpt.fyi]: ERROR [GitHub], SKIP [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt] (Chrome: OK, Safari: ERROR)

Tests Disabled in Gecko Infrastructure

• /css/css-typed-om/stylevalue-subclasses/cssRGB.html [wpt.fyi]: ERROR [GitHub], SKIP [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt] (Chrome: OK, Safari: ERROR)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f1c3e2479096
[wpt PR 36717] - Align cssRGB.html with the specification and fix mistake, a=testonly

Comment 4

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/f1c3e2479096