1798067 - Add telemetry for HDR capability based on per-platform capability detection

Status: RESOLVED FIXED

(Core :: Graphics, task)

Description

[Brad Werth [:bradwerth]]

It would be useful to know how many of our clients are capable of viewing HDR video. This telemetry should be emitted infrequently because it will not change regularly. So instead of including it in the general metrics ping, we could define a graphics-specific metrics ping at a longer cadence.

There are at least two ways to signal HDR capability:

1. Emit telemetry per-platform based on hardware detection customized to that platform.
2. Emit telemetry for all clients, based on our reported support for HDR video, which is informed by Option 1.

Option 2 is what is being proposed by this Bug. Bug 1751217 caused macOS to report HDR via matching of video-dynamic-range: high, which is checked by YouTube. So emitting telemetry based on matching this value will magically capture other platforms when and if they start reporting HDR capabilities this way.

Currently, the Windows-specific HDR telemetry in Bug 1514840 does not affect the matching of video-dynamic-range: high. If it ever does, then this mode of emitting capability telemetry will start to include results for Windows clients.

Comment 1

[Brad Werth [:bradwerth]]

Changed my thinking on this. We already collect telemetry about HDR usage via video_hdr_play_time_ms. What we need is telemetry that shows the addressable user base -- measuring the possibility of HDR. So this Bug will abstract the per-platform HDR capability check into a new enum, hdr_capable.

Comment 2

[Brad Werth [:bradwerth]]

Attachment: Bug 1798067 Part 1: Add SupportsHDR to gfxPlatform, refactor macOS to use it.

Comment 3

[Brad Werth [:bradwerth]]

Attachment: Bug 1798067 Part 2: Implement gfxWindowsPlatform::SupportsHDR.

Comment 4

[Brad Werth [:bradwerth]]

Attachment: Bug 1798067 Part 3: Emit telemetry for gfx.supports_hdr alongside other gfx telemetry.

Depends on D161365

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1b59437ed62b
Part 1: Add SupportsHDR to gfxPlatform, refactor macOS to use it. r=gfx-reviewers,lsalzman
https://hg.mozilla.org/integration/autoland/rev/f87001406f29
Part 2: Implement gfxWindowsPlatform::SupportsHDR. r=jgilbert,gfx-reviewers
https://hg.mozilla.org/integration/autoland/rev/dba34dc9a166
Part 3: Emit telemetry for gfx.supports_hdr alongside other gfx telemetry. r=gfx-reviewers,nical

Comment 6

[Atila Butkovits]

Backed out for causing bustages at gfxPlatformMac.cpp.

Backout link: https://hg.mozilla.org/integration/autoland/rev/89dacc8bb0b6ded1d877c8f37f04b99bc1a1c94a

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=RpIsEGmGRP2r7s3zTTcHyw.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=dba34dc9a16670d983af1564555e64542874b8bd

Failure log: https://treeherder.mozilla.org/logviewer?job_id=397953357&repo=autoland&lineNumber=15871

Comment 7

[Atila Butkovits]

And there is also this: https://treeherder.mozilla.org/logviewer?job_id=397956009&repo=autoland&lineNumber=1222

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/324b83e29ae6
Part 1: Add SupportsHDR to gfxPlatform, refactor macOS to use it. r=gfx-reviewers,lsalzman
https://hg.mozilla.org/integration/autoland/rev/fad1872ea963
Part 2: Implement gfxWindowsPlatform::SupportsHDR. r=jgilbert,gfx-reviewers
https://hg.mozilla.org/integration/autoland/rev/fd40e36100cc
Part 3: Emit telemetry for gfx.supports_hdr alongside other gfx telemetry. r=gfx-reviewers,nical

Comment 9

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/324b83e29ae6
https://hg.mozilla.org/mozilla-central/rev/fad1872ea963
https://hg.mozilla.org/mozilla-central/rev/fd40e36100cc