Open Bug 1798075 Opened 2 years ago Updated 17 days ago

Clipped text drawing with macOS SW-WR: Address bar text overlay in safe mode when theme is installed

Categories

(Core :: Graphics: WebRender, defect)

Firefox 108
Desktop
macOS
defect

Tracking

()

Tracking Status
firefox-esr102 --- wontfix
firefox107 --- wontfix
firefox108 --- wontfix
firefox109 --- wontfix

People

(Reporter: TheOne, Assigned: bradwerth, NeedInfo)

References

(Blocks 3 open bugs, Regression)

Details

(Keywords: regression)

Attachments

(1 file)

Attached image screenshot.png

I noticed that when a theme is enabled and you enter safe mode, for wide or large window sizes, some overlay appears over the address bar text.

STR:

  1. Enable Alpenglow theme
  2. Restart Firefox in safe mode
  3. Open a page with a long url, like https://versioncheck.addons.mozilla.org/update/VersionCheck.php?reqVersion=2&id=jid1-yRtlFKrTMBrAtQ@jetpack&version=1.1.0&maxAppVersion=*&status=userDisabled&appID={ec8030f7-c20a-464f-9b0e-13a3a9e97384}&appVersion=107.0&appOS=Darwin&appABI=x86_64-gcc3&locale=en-US&currentAppVersion=107.0&updateType=97&compatMode=normal
  4. Resize window to large width or height (or both)

Tested on Firefox 108.0a1 (20221028094453) on MacOS 13

The severity field is not set for this bug.
:adw, could you have a look please?

For more information, please visit auto_nag documentation.

Flags: needinfo?(adw)

Looked for regression range and it seems that this issue has been introduced in 92.0a1 (between 2021-07-20 and 2021-07-21).
Here's the pushlog that mozregression pointed to: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=3d302847f025b332190a747a21bb1fedaa5e7b98&tochange=ee40230413eb08737e07b2e62514d67961d355db.

Has STR: --- → yes
Keywords: regression
OS: Unspecified → macOS
Hardware: Unspecified → Desktop
Version: unspecified → Firefox 108

Thanks Catalin. Two bugs stand out:

  • Bug 1721626 - Safe mode should default to Software WebRender, no acceleration instead of Basic
  • Bug 1711261 - Address bar and Search bar lack contrast in OSX High Contrast mode

This isn't the kind of bug that's caused by a front-end CSS change, at least not alone, so I suspect bug 1721626. I'll tentatively set it as the regressor and move this to the same component.

Component: Address Bar → Graphics: WebRender
Flags: needinfo?(adw)
Product: Firefox → Core
Regressed by: 1721626

Set release status flags based on info from the regressing bug 1721626

:aosmond, since you are the author of the regressor, bug 1721626, could you take a look? Also, could you set the severity field?

For more information, please visit auto_nag documentation.

Instead of safe mode, if you go to about:config and set gfx.webrender.software to true, and restart normally, do you see the same issue? This sounds like a bug rendering software WebRender on OSX specifically. RenderCompositorNative pathways probably don't get used much as most Mac users will be on HW-WR.

Severity: -- → S3
Flags: needinfo?(aosmond) → needinfo?(awagner)

(In reply to Andrew Osmond [:aosmond] (he/him) from comment #5)

Instead of safe mode, if you go to about:config and set gfx.webrender.software to true, and restart normally, do you see the same issue? This sounds like a bug rendering software WebRender on OSX specifically. RenderCompositorNative pathways probably don't get used much as most Mac users will be on HW-WR.

Yes, I can reproduce in regular mode with gfx.webrender.software set to true.

Flags: needinfo?(awagner)
Summary: Address bar text overlay in safe mode when theme is installed → Clipped text drawing with macOS SW-WR: Address bar text overlay in safe mode when theme is installed

Any ideas what could cause this Lee?

Flags: needinfo?(lsalzman)

I'll try to reproduce and see what we can do.

Assignee: nobody → bwerth
No longer blocks: gfx-triage
Flags: needinfo?(lsalzman)

I can't reproduce this on macOS with gfx.webrender.software set to true, and restarting in Troubleshoot Mode (formerly Safe Mode) turns off the theme, which also prevents it from happening. Is this still happening for you?

Flags: needinfo?(awagner)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: