1798207 - highlight all quits working on some pages

Status: RESOLVED FIXED

(Core :: Find Backend, defect)

Description

[zlice]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:108.0) Gecko/20100101 Firefox/108.0

Steps to reproduce:

possible old dupe https://bugzilla.mozilla.org/show_bug.cgi?id=1344309

https://www.ign.com/wikis/re2-remake/All_Safe_and_Lock_Combinations,_Codes,_and_Solutions

ctrl+f to find "statue"

hit enter

Actual results:

highlights vanish when moving around page (similar to unchecking 'highlight all')

Expected results:

continue highlighting all

I have another 'find highlight' issue where the checkbox for 'highlight all' will untoggle itself randomly, but even toggling the option does not re-highlight in this case.

This happens in a private browser and after clearing cache.

Comment 1

[Alice0775 White]

Regression window:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=79197e2d630ab38e53971c7e9a5b028940a05b63&tochange=9849ea3937e2e7c97f79b1d2b601f956181b4629

Probably, Regressed by Bug 1455891.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

:emilio, since you are the author of the regressor, bug 1455891, could you take a look? Also, could you set the severity field?

For more information, please visit auto_nag documentation.

Comment 3

[Alice0775 White]

Interestingly,

1. Open https://www.ign.com/wikis/re2-remake/All_Safe_and_Lock_Combinations,_Codes,_and_Solutions
2. ctrl+f to find "Statue" (capital letter)
3. Turn on Highlight All

  1 of 13 matches --- as expected
  No highlight all  --- This Bug

4. Turn on Match Case

  1 of 12 matches --- as expected, off cause (non-capital letter) is ignored.
  Highlight all performed --- as expected

Comment 4

[Emilio Cobos Álvarez [:emilio]]

Attachment: Reduced test-case.

Comment 5

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1798207 - Use shadow-including tree order to sort selection ranges. r=smaug

So that painting code doesn't get confused when trying to paint
selections that span across shadow boundaries.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c73d7c982726
Use shadow-including tree order to sort selection ranges. r=smaug

Comment 7

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/36929 for changes under testing/web-platform/tests

Comment 8

[Atila Butkovits]

Backed out for causing failures at Range-comparePoint.html.

Backout link: https://hg.mozilla.org/integration/autoland/rev/499456f37b2dcf06fce81c50ac81729b7a37105f

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=EW27GcziTl6s9eoK5Y-B4Q.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=c73d7c982726df22bd6cbc358d0094967ea44ca0

Failure log:

• https://treeherder.mozilla.org/logviewer?job_id=396265924&repo=autoland&lineNumber=1684
• https://treeherder.mozilla.org/logviewer?job_id=396265977&repo=autoland&lineNumber=3574

Comment 9

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR was closed without merging

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/953cb813940f
Use shadow-including tree order to sort selection ranges. r=smaug

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e8ed44897a81
Revert ThrowDocumentError change.

Comment 12

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/953cb813940f
https://hg.mozilla.org/mozilla-central/rev/e8ed44897a81

Comment 13

[Rares Doghi, Desktop QA]

Verified as fixed in our latest build 108.0a1 (2022-11-12).

Comment 14

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot