Closed Bug 179823 Opened 22 years ago Closed 22 years ago

Addressbook Sort/Search by phonetic name

Categories

(SeaMonkey :: MailNews: Address Book & Contacts, defect)

defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED
mozilla1.3alpha

People

(Reporter: nhottanscp, Assigned: nhottanscp)

References

Details

(Keywords: intl)

Attachments

(1 file, 2 obsolete files)

Separated from bug 178891.
For builds which phonetic fields are enabled (it is disabled as default),
* Need sort by phonetic.
* Search by name should also search phonetic names.
QA Contact: nbaca → ji
Keywords: intl
Target Milestone: --- → mozilla1.3alpha
In the patch,
* Company.accesskey is changed from "O" to "C".
* Phonetic column in address book is disabled as default (but exists in the
column list)
Attachment #106426 - Flags: review?(cavin)
Comment on attachment 106426 [details] [diff] [review]
Adding phonetic sort/search support.

Make sure auguments 'card' and 'aName' are not null in
GeneratePhoneticNameFromCard(). Other than that r=cavin.
Attachment #106426 - Flags: review?(cavin) → review+
Attached patch Added argument checks. (obsolete) — Splinter Review
Attachment #106426 - Attachment is obsolete: true
Attachment #106441 - Flags: superreview?(sspitzer)
Comment on attachment 106441 [details] [diff] [review]
Added argument checks.

sr=sspitzer once you address these nits / comments:

1) 

I think when the _PhoneticName column is hidden, we'll have two splitters.

should we hide the new splitter (and show it) as well?

2)

+  nsresult rv;
...
+  rv = card->GetPhoneticFirstName(getter_Copies(firstName));

can you just do:

nsresult rv = card->GetPhoneticFirstName(getter_Copies(firstName));

3)

-<!ENTITY Company.label "Organization">
-<!ENTITY Company.accesskey "O">
+<!ENTITY Company.label "Company">
+<!ENTITY Company.accesskey "C">

why the switch from Organization to Company?
(is that an ishmail change?  do we want to do that on the trunk?)

can you check with robinf / jglick?

4)

GeneratePhoneticNameFromCard(nsIAbCard *card, PRBool lastNameFirst

can you make it aCard and aLastNameFirst?
1)
>I think when the _PhoneticName column is hidden, we'll have two splitters.

do you mean splitter in abResultsPaneOverlay.xul?
+  <treecol id="_PhoneticName" class="sortDirectionIndicator" 
+    persist="hidden ordinal width" 
+    hiddenbydefault="true"
+    flex="1" label="&_PhoneticName.label;"/>
+  <splitter class="tree-splitter"/>

3)
Yes, I contacted her before
Jennifer, is this change okay?

-<!ENTITY Company.label "Organization">
-<!ENTITY Company.accesskey "O">
+<!ENTITY Company.label "Company">
+<!ENTITY Company.accesskey "C">
> Where are we going to have two splitters?

from your patch:

 <treecol id="Company" class="sortDirectionIndicator" 
     persist="hidden ordinal width" flex="1" label="&Company.label;"/>
   <splitter class="tree-splitter"/>
+  <treecol id="_PhoneticName" class="sortDirectionIndicator" 
+    persist="hidden ordinal width" 
+    hiddenbydefault="true"
+    flex="1" label="&_PhoneticName.label;"/>
+  <splitter class="tree-splitter"/>
   <treecol id="NickName" class="sortDirectionIndicator" 

when the _PhoneticName treecol is hidden we have splitter / splitter.  Is that a
problem?
>why the switch from Organization to Company?

This came up because of a mnemonics conflict. Either is fine with me, but 
Company seems to be more common:
Outlook, OE, AOL, Yahoo, Hotmail use "Company".
Eudora uses "Organization".
I prefer "Company".
I commented out treecol and splitter for phonetic and localizer may enable it.
Attachment #106441 - Attachment is obsolete: true
Attachment #106819 - Flags: superreview?(sspitzer)
Blocks: 181883
Comment on attachment 106819 [details] [diff] [review]
Updated to include changes for review's comment.

sr=sspitzer

sorry for the delay.
Attachment #106819 - Flags: superreview?(sspitzer) → superreview+
checked in to the trunk
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
"mail.addr_book.show_phonetic_fields"
set this to "true" to enable phonetic name in address book.
With the entry added in prefs.js file, the phonetic fields show on New/Edit Card
UI, but not on Address Book main window.
I forgot to mention that the column is disabled as default and need to edit
addressbook.xul in order to localize for JA.
I mean this.

Index: addrbook/resources/content/addressbook.xul
===================================================================
RCS file: /cvsroot/mozilla/mailnews/addrbook/resources/content/addressbook.xul,v
retrieving revision 1.157
diff -u -r1.157 addressbook.xul
--- addrbook/resources/content/addressbook.xul	3 Oct 2002 11:13:46 -0000	1.157
+++ addrbook/resources/content/addressbook.xul	19 Nov 2002 20:19:50 -0000
@@ -240,6 +240,15 @@
                                   id="cmd_SortByCompany"
                                   accesskey="&Company.accesskey;"
                                   oncommand="SortResultPane('Company');"
name="sortas" type="radio" checked="true"/>
+            <!-- LOCALIZATION NOTE:
+             Fields for phonetic are disabled as default and can be enabled by 
+             editing "mail.addr_book.show_phonetic_fields"    
+             -->
+            <menuitem label="&_PhoneticName.label;"
+                                  id="cmd_SortBy_PhoneticName"
+                                  hidden="true"
+                                  accesskey="&_PhoneticName.accesskey;"
+                                  oncommand="SortResultPane('_PhoneticName');"
name="sortas" type="radio" checked="true"/>
             <menuitem label="&NickName.label;"
                                   id="cmd_SortByNickName"
                                   accesskey="&NickName.accesskey;"
The info I put in comment #16 is incorrect.
Here is how to enable the feature for testing (and localization).

1) 
user_pref("mail.addr_book.show_phonetic_fields", "true"); 

2)
user_pref("mail.addr_book.quicksearchquery.format",
"?(or(PrimaryEmail,c,@V)(DisplayName,c,@V)(FirstName,c,@V)(LastName,c,@V)(PhoneticFirstName,c,@V)(PhoneticLastName,c,@V))");

3) Uncomment "_PhoneticName".
Index: addrbook/resources/content/abResultsPaneOverlay.xul
===================================================================
RCS file:
/cvsroot/mozilla/mailnews/addrbook/resources/content/abResultsPaneOverlay.xul,v
retrieving revision 1.13
diff -u -r1.13 abResultsPaneOverlay.xul
--- addrbook/resources/content/abResultsPaneOverlay.xul	11 Sep 2002 07:06:02
-0000	1.13
+++ addrbook/resources/content/abResultsPaneOverlay.xul	19 Nov 2002 20:19:50 -0000
@@ -70,6 +70,14 @@
   <treecol id="Company" class="sortDirectionIndicator" 
     persist="hidden ordinal width" flex="1" label="&Company.label;"/>
   <splitter class="tree-splitter"/>
+  <!-- LOCALIZATION NOTE: _PhoneticName may be enabled for Japanese builds. -->
+  <!--
+  <treecol id="_PhoneticName" class="sortDirectionIndicator" 
+    persist="hidden ordinal width" 
+    hiddenbydefault="true"
+    flex="1" label="&_PhoneticName.label;"/>
+  <splitter class="tree-splitter"/>
+   -->
   <treecol id="NickName" class="sortDirectionIndicator" 
     persist="hidden ordinal width" 
     hiddenbydefault="true"
Thanks Naoki for the detailed info.
Both search and sorting work well on 12/03 build for Japanese data after I
modified the xul and prefs.js file based on Naoki's instruction.
Status: RESOLVED → VERIFIED
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: