1798232 - Duplicating a tab after moving to a new window opens wrong site

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, defect, P3)

Description

[Calvin Luo]

Steps to reproduce:

I can reproduce on a new Firefox profile and the latest Nightly (Build ID 20221030090504) by following these steps:

1. Open a new tab, paste https://example.com in the address bar, and press Enter.
2. Move the tab to a new window. (Right click the tab for context menu -> Move Tab -> Move to New Window. If this option is disabled, first open another tab so there is more than one tab in the window.)
3. Duplicate the tab. (Right click the tab for context menu -> Duplicate Tab.)

Actual results:

Another tab is opened to the site before navigation to https://example.com.

Expected results:

Another tab is opened to https://example.com.

Comment 1

[Alice0775 White]

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=b79ebf7f49d8e071c6ceec3f9d19852bf2eba4fe&tochange=2e7ecad460f2be1275a59b7f55c4ff5a8fe3274e

Tentatively marked Bug 1756995 as a regressor.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

:farre, since you are the author of the regressor, bug 1756995, could you take a look? Also, could you set the severity field?

For more information, please visit auto_nag documentation.

Comment 3

[Andreas Farre [:farre]]

If you do:

1. Open a new tab, paste https://example.com in the address bar, and press Enter.
2. Wait for more than 15 seconds
3. Move the tab to a new window. (Right click the tab for context menu -> Move Tab -> Move to New Window. If this option is disabled, first open another tab so there is more than one tab in the window.)
4. Duplicate the tab. (Right click the tab for context menu -> Duplicate Tab.)

then this does not reproduce. And the reason for this is that the session store tab state hasn't been flushed before moving the window.

Comment 4

[Andreas Farre [:farre]]

Turns out that the problem is that we don't explicitly flush a tab's session store state before moving, and the reason that bug 1756995 regressed this is that nsDocShell::EndPageLoad used to force a flush (which was bad), but bug 1756995 fixed that. And then this issue surfaced.

Comment 5

[Andreas Farre [:farre]]

Fix is running on try: https://treeherder.mozilla.org/jobs?repo=try&revision=692db56271338da4c8b196212c4cf0ee7df3a62d

Comment 6

[Andreas Farre [:farre]]

Attachment: Bug 1798232 - Make sure to flush session store when moving tabs to new window. r=dao!

When moving a tab to a new window, the tab state needs to be flushed
and then copied over. Copying the current state could possibly miss
out on any buffered changes. Unfortunately we can't wait for the flush
to complete and then move, so we need to force the old state on top of
the new.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d8b63736e65e
Make sure to flush session store when moving tabs to new window. r=dao

Comment 8

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/d8b63736e65e

Comment 9

[Alin Ilea, Desktop Test Engineering]

Reproduced the issue in Beta 107.0b8 using Windows 10.
Verified - Fixed in latest Nightly 108.0a1 (build id: 20221102174350).