1798238 - FolderDisplayHelpers.jsm:3320 - TypeError: testHelperModule.dump_view_state is not a function

Status: RESOLVED FIXED

(Thunderbird :: Testing Infrastructure, defect)

Description

[Magnus Melin [:mkmelin]]

In case of test failure, like https://treeherder.mozilla.org/logviewer?job_id=394873612&repo=comm-central we fail out trying to display details about the failure.

TEST-UNEXPECTED-FAIL | comm/mail/test/browser/quick-filter-bar/browser_filterLogic.js | Uncaught exception in test - at resource://testing-common/mozmill/FolderDisplayHelpers.jsm:3320 - TypeError: testHelperModule.dump_view_state is not a function

viewWrapperTestUtils.js which has dump_view_state is not loaded in FolderDisplayHelpers.jsm

Probably best to move that function into FolderDisplayHelpers.jsm, or at least into a module. Or drop it completely...

Comment 1

[Magnus Melin [:mkmelin]]

Attachment: Bug 1798238 - move dump_view_state and friends to ViewHelpers.jsm. r=#thunderbird-reviewers

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/6a6b2c6ba5e5
move dump_view_state and friends to FolderDisplayHelpers.jsm. r=aleca

Comment 3

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/comm-central/rev/a0cddf6aa7c2
Backed out changeset 6a6b2c6ba5e5 for test failures

Comment 4

[Magnus Melin [:mkmelin]]

Tests crashing since FolderDisplayHelpers.jsm imports controller.jsm. Very odd.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/ae91a2ac4a28
move dump_view_state and friends to ViewHelpers.jsm. r=aleca