Closed
Bug 1798335
Opened 2 years ago
Closed 1 year ago
Replace the toggle in about:addons with moz-toggle
Categories
(Toolkit :: UI Widgets, task)
Toolkit
UI Widgets
Tracking
()
RESOLVED
FIXED
111 Branch
Tracking | Status | |
---|---|---|
firefox111 | --- | fixed |
People
(Reporter: hjones, Assigned: hjones)
References
(Blocks 1 open bug)
Details
(Whiteboard: [recomp])
Attachments
(2 files)
Bug 1795306 introduces a new <fx-toggle>
custom element intended to help us standardize our toggle implementations across desktop surfaces.
As a next step, this toggle in aboutaddons.html
should be updated to use the new element.
Assignee | ||
Updated•2 years ago
|
Blocks: reusable-components
Assignee | ||
Comment 1•2 years ago
|
||
- replaced the toggle in the addons card that controls enabling/disabling the addon
- replaced the toggle that controls optional permissions
- fixed tests, added overrides for fx-toggle styles
Assignee | ||
Updated•2 years ago
|
Blocks: moz-toggle
Assignee | ||
Updated•2 years ago
|
No longer blocks: reusable-components
Updated•2 years ago
|
Whiteboard: [fidefe-reusable-components-ms1]
Updated•2 years ago
|
Updated•1 year ago
|
Attachment #9301165 -
Attachment description: Bug 1798335 - replace aboutaddons toggles with fx-toggle r=mstriemer → Bug 1798335 - replace aboutaddons toggles with moz-toggle r=mstriemer
Pushed by hjones@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/fab977235136 replace aboutaddons toggles with moz-toggle r=mstriemer,desktop-theme-reviewers,dao,sfoster
Comment 3•1 year ago
|
||
Backed out changeset fab977235136 (Bug 1798335) for causing bc failures on browser_extension_sideloading.js.
Backout link
Push with failures <--> bc11
Failure Log
Flags: needinfo?(hjones)
Pushed by hjones@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/988871602360 replace aboutaddons toggles with moz-toggle r=mstriemer,desktop-theme-reviewers,dao,sfoster
Comment 5•1 year ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 1 year ago
status-firefox111:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 111 Branch
Assignee | ||
Updated•1 year ago
|
Flags: needinfo?(hjones)
Comment 6•1 year ago
|
||
Pushed by geoff@darktrojan.net: https://hg.mozilla.org/comm-central/rev/3f114767a6d3 Port Bug 1798335 - Replace the toggle in about:addons with fx-toggle. r=aleca
Comment 8•1 year ago
|
||
A patch has been attached on this bug, which was already closed. Filing a separate bug will ensure better tracking. If this was not by mistake and further action is needed, please alert the appropriate party. (Or: if the patch doesn't change behavior -- e.g. landing a test case, or fixing a typo -- then feel free to disregard this message)
Updated•11 months ago
|
Summary: Replace the toggle in about:addons with fx-toggle → Replace the toggle in about:addons with moz-toggle
Updated•2 months ago
|
Whiteboard: [fidefe-reusable-components-ms1] → [recomp]
You need to log in
before you can comment on or make changes to this bug.
Description
•