Closed Bug 1798335 Opened 2 years ago Closed 1 year ago

Replace the toggle in about:addons with moz-toggle

Categories

(Toolkit :: UI Widgets, task)

task

Tracking

()

RESOLVED FIXED
111 Branch
Tracking Status
firefox111 --- fixed

People

(Reporter: hjones, Assigned: hjones)

References

(Blocks 1 open bug)

Details

(Whiteboard: [recomp])

Attachments

(2 files)

Bug 1795306 introduces a new <fx-toggle> custom element intended to help us standardize our toggle implementations across desktop surfaces.

As a next step, this toggle in aboutaddons.html should be updated to use the new element.

  • replaced the toggle in the addons card that controls enabling/disabling the addon
  • replaced the toggle that controls optional permissions
  • fixed tests, added overrides for fx-toggle styles
Blocks: moz-toggle
No longer blocks: reusable-components
Whiteboard: [fidefe-reusable-components-ms1]
Attachment #9301165 - Attachment description: Bug 1798335 - replace aboutaddons toggles with fx-toggle r=mstriemer → Bug 1798335 - replace aboutaddons toggles with moz-toggle r=mstriemer
Pushed by hjones@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/fab977235136
replace aboutaddons toggles with moz-toggle r=mstriemer,desktop-theme-reviewers,dao,sfoster

Backed out changeset fab977235136 (Bug 1798335) for causing bc failures on browser_extension_sideloading.js.
Backout link
Push with failures <--> bc11
Failure Log

Flags: needinfo?(hjones)
Pushed by hjones@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/988871602360
replace aboutaddons toggles with moz-toggle r=mstriemer,desktop-theme-reviewers,dao,sfoster
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 111 Branch
Flags: needinfo?(hjones)
Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/3f114767a6d3
Port Bug 1798335 - Replace the toggle in about:addons with fx-toggle. r=aleca

A patch has been attached on this bug, which was already closed. Filing a separate bug will ensure better tracking. If this was not by mistake and further action is needed, please alert the appropriate party. (Or: if the patch doesn't change behavior -- e.g. landing a test case, or fixing a typo -- then feel free to disregard this message)

Blocks: 1722643
Summary: Replace the toggle in about:addons with fx-toggle → Replace the toggle in about:addons with moz-toggle
Whiteboard: [fidefe-reusable-components-ms1] → [recomp]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: