Closed Bug 1798339 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 36740 - Remove reliance on "global" mutable state.

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox108 fixed)

Status:
RESOLVED FIXED
Milestone:
108 Branch
Tracking Flags:
Tracking Status
firefox108 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 36740 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/36740
Details from upstream follow.

Chris Fredrickson <cfredric@chromium.org> wrote:

Remove reliance on "global" mutable state.

This helper attempted to use g_clickID to give each button a unique
ID, but didn't account for the fact that different instances of the
script have their own variables, so that variable isn't truly global,
and therefore IDs can be reused across iframes. This CL avoids this
issue by making the caller provide the ID explicitly, so it's at least
more obvious if two invocations of the helper reuse the same ID.

(I found this issue while debugging crbug.com/1379595, and while this
wasn't the cause of that bug, I still think it's worth fixing.)

Bug: 1379595
Change-Id: Ie208bae11d5eb87d9bbc9bb11aff68ce540d71a7

Reviewed-on: https://chromium-review.googlesource.com/3993924
WPT-Export-Revision: 6805006336dedff983c518097b0f0ad9cc06d37e

PR 36740 applied with additional changes from upstream: 5098f818e7fb02aa1c288b42085cc1b9dcda12cd

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 3 tests and 5 subtests

Status Summary

Firefox

OK : 2
PASS : 27
FAIL : 3
TIMEOUT: 2
NOTRUN : 2

Chrome

OK : 2
PASS : 2
FAIL : 18
ERROR : 1

Safari

OK : 3
PASS : 20
FAIL : 13

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

  • /storage-access-api/requestStorageAccess.sub.window.html [wpt.fyi]: TIMEOUT (Chrome: ERROR, Safari: OK)
    • [non-fully-active] document.requestStorageAccess() should not resolve when run in a detached frame: TIMEOUT (Safari: FAIL)
    • [non-fully-active] document.requestStorageAccess() should not resolve when run in a detached DOMParser document: NOTRUN (Safari: FAIL)
    • [top-level-context] document.requestStorageAccess() should be resolved when called properly with a user gesture: NOTRUN (Safari: FAIL)
  • /storage-access-api/storageAccess.testdriver.sub.html [wpt.fyi]
    • Set up storage access rules: FAIL (Chrome: FAIL, Safari: FAIL)
    • [third-party-blocked-on-first-party-site] Cookie access is allowed: false: FAIL (Chrome: FAIL, Safari: FAIL)
    • [third-party-blocked-all] Cookie access is allowed: false: FAIL (Chrome: FAIL, Safari: FAIL)
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3e77bca9f003 [wpt PR 36740] - Remove reliance on "global" mutable state., a=testonly

https://hg.mozilla.org/mozilla-central/rev/3e77bca9f003

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox108: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 108 Branch
You need to log in before you can comment on or make changes to this bug.