1798387 - Implement SERP telemetry for Ecosia

Status: VERIFIED FIXED

(Firefox :: Search, task, P2)

Description

[Stephanie Cunnane [:scunnane]]

We need to implement SERP telemetry for both the Ecosia and Qwant search engines. We'll make use of existing telemetry probes and apply them to these 2 additional partners. No new telemetry probes will be created.

Comment 1

[Stephanie Cunnane [:scunnane]]

Attachment: Bug 1798387 - Implement SERP telemetry for Ecosia. r?standard8,mcheang

Comment 2

[Mark Banner (:standard8)]

Adrian, the changes here are now on stage-preview. Qwant and Ecosia SERP telemetry will only be added for 110a1 and later (this is using remote settings version filtering), due to the fixes required in bug 1804739. The SERP telemetry for them runs the same as for the other engines that it is recorded.

Yahoo SERP telemetry has also been removed.

Comment 3

[Adrian Florinescu [:aflorinescu]]

Thank you for the update, we'll get to it as soon as possible.
Do you think we need to do special verification for bug 1804739 or any regression areas that might be affected?

Comment 4

[Mark Banner (:standard8)]

(In reply to Adrian Florinescu [:aflorinescu] from comment #3)

Do you think we need to do special verification for bug 1804739 or any regression areas that might be affected?

You could do a check to ensure that with_ads/ad_clicks are correctly recorded for the other engines for 110 & later. I don't think it needs to be massively in-depth.

Comment 5

[Adrian Florinescu [:aflorinescu]]

Testing completed for stage-preview, with both ecosia and qwant search engines and a small area regression testing. Since this is a change that only affects 110+, we're going to be covering a much wider regression area in the Nightly 110 Search Regression test run, which is planned before the nightly110 merge to beta110. We took this oportunity to also add test coverage for both of the above search engines SAP and SERP.

For more details, please see Testrun:

• the only issues encountered were related to the follow-up searches with both engines. These have been reported to eng and additional follow-up is required to figure out the following steps there, so for the time being those are not covered by any logged bugs, but marked as failed into the test run.

Comment 6

[Mark Banner (:standard8)]

Due to the problems with Qwant not working with follow-up telemetry we are deferring that to a different bug and going with only enabling Ecosia for now.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/03f1acdf4d8e
Implement SERP telemetry for Ecosia. r=Standard8

Comment 8

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/03f1acdf4d8e

Comment 9

[Cristian Baica [:cbaica], Release Desktop QA]

Closing this as verified fixed. Ecosia telemetry has been extensively covered also included in the QA nightly 110 search regression testing.