1798433 - [wpt-sync] Sync PR 36756 - [anchor-position] Implement scroll-aware position fallback

Status: RESOLVED INVALID

(Core :: CSS Parsing and Computation, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 36756 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/36756
Details from upstream follow.

Xiaocheng Hu <[e-mail]> wrote:

[anchor-position] Implement scroll-aware position fallback

WIP

This patch brings scroll offset into position fallback algorithm to
decide which fallback position to use, and also calculates info to
help decide when to invalidate the current fallback position.

Bug: 1371217
Change-Id: I5256b1422e6f48cfbb1c70e6f47c7e65362d3496

Reviewed-on: https://chromium-review.googlesource.com/3995704
WPT-Export-Revision: 0ed899d665a222261ffa2381fcb2b6c092757561

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=f2d73d6caa5a022e7cd1b7968ba6f2153478f692

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 5 tests and 2 subtests

Status Summary

Firefox

OK : 5
FAIL: 14

Chrome

OK : 5
PASS: 7
FAIL: 7

Safari

OK : 5
FAIL: 14

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /css/css-anchor-position/anchor-scroll-fallback-position-001.html [wpt.fyi]
  • Should be above the anchor when at initial scroll position: FAIL (Chrome: PASS, Safari: FAIL)
  • Scroll down until the top edge of #anchor touches container but not overflowing: FAIL (Chrome: PASS, Safari: FAIL)
  • Scroll further down, making the first fallback position overflow by 1px: FAIL (Chrome: FAIL, Safari: FAIL)
  • Scroll back up to reuse the first fallback position: FAIL (Chrome: PASS, Safari: FAIL)
  • Scroll bottom-right to make the first three fallback positions overflow: FAIL (Chrome: FAIL, Safari: FAIL)
• /css/css-anchor-position/anchor-scroll-fallback-position-002.html [wpt.fyi]
  • Should use the first fallback position at the initial scroll offset: FAIL (Chrome: PASS, Safari: FAIL)
  • Should use the second fallback position after scrolling left: FAIL (Chrome: FAIL, Safari: FAIL)
• /css/css-anchor-position/anchor-scroll-fallback-position-003.html [wpt.fyi]
  • Should use the first fallback position at the initial scroll offset: FAIL (Chrome: PASS, Safari: FAIL)
  • Should use the second fallback position after scrolling up: FAIL (Chrome: FAIL, Safari: FAIL)
• /css/css-anchor-position/anchor-scroll-fallback-position-004.html [wpt.fyi]
  • Should use the first fallback position at the initial scroll offsets: FAIL (Chrome: PASS, Safari: FAIL)
  • Should use the second fallback position after scrolling viewport down: FAIL (Chrome: FAIL, Safari: FAIL)
  • Should use the third fallback position after scrolling the vrl scroller left: FAIL (Chrome: FAIL, Safari: FAIL)
• /css/css-anchor-position/anchor-scroll-fallback-position-005.html [wpt.fyi]
  • Should use the first fallback position at the initial scroll offset: FAIL (Chrome: PASS, Safari: FAIL)
  • Should use the second fallback position after scrolling left: FAIL (Chrome: FAIL, Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/691ac08af692
[wpt PR 36756] - [anchor-position] Implement scroll-aware position fallback, a=testonly
https://hg.mozilla.org/integration/autoland/rev/dea325b067fa
[wpt PR 36756] - Update wpt metadata, a=testonly

Comment 4

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/691ac08af692
https://hg.mozilla.org/mozilla-central/rev/dea325b067fa