1798483 - dev tool not resizing with firefox window

Status: VERIFIED FIXED

(DevTools :: Inspector, defect, P3)

Description

[hugo.bonpain]

Attachment: temp.mp4

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:107.0) Gecko/20100101 Firefox/107.0

Steps to reproduce:

• Open new firefox developper edition window
• Push it in a corner so it resizes itself at 1/4 of the screen
• Open dev tools
• Resize the firefox window from the bottom upwards

Actual results:

See linked video

Expected results:

Devtools should resize with firefox window

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::Graphics' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[Brad Werth [:bradwerth]]

I can reproduce with Developer Edition 107.0b7 on macOS. I'll see if I can get mozregression to work with Developer Edition builds to isolate the change that caused this. Meanwhile, I'll change the component to DevTools.

Comment 3

[Brad Werth [:bradwerth]]

I can reproduce in any version of Firefox. Revised STR:

1. New Firefox window.
2. Open DevTools Inspector.
3. Vertically shrink the window from the bottom until the Styles panel gets compressed and clipped.
4. Scroll down in the Styles panel.

Expected results:
The scroll tab remains in the visible portion of the window. All of the content can be scrolled into view.

Actual results:
The scroll tab disappears off the bottom of the panel. Some of the content at the end of the Styles panel can't be scrolled into view.

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

:emilio, since you are the author of the regressor, bug 1789168, could you take a look?

For more information, please visit auto_nag documentation.

Comment 5

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1798483 - Improve behavior of devtools splitting to prevent overflow. r=jdescottes

Use resizebefore/after=sibling to avoid setting the width of anything
else that isn't the DevTools frame, and make the size not impose a min
size to allow it to shrink.

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1789168

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d7d3e5b8315d
Improve behavior of devtools splitting to prevent overflow. r=jdescottes

Comment 8

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/d7d3e5b8315d

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:emilio, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox107 to wontfix.

For more information, please visit auto_nag documentation.

Comment 10

[Emilio Cobos Álvarez (:emilio)]

Julian, do you think this should ride the trains? In principle it shouldn't be too risky, but it's kinda late in the 107 cycle I think.

Comment 11

[Julian Descottes [:jdescottes]]

(In reply to Emilio Cobos Álvarez (:emilio) from comment #10)

Julian, do you think this should ride the trains? In principle it shouldn't be too risky, but it's kinda late in the 107 cycle I think.

Today is the last day for beta uplift requests, but I think this bug is worth uplifting. The main reason for me is that the issue persists even after you close devtools, or if you go to another tab. So any DevTools user who resized a toolbox might have a bad overall experience with Firefox in 107. If this only occurred while the toolbox was opened, it would be a different story.

But I defer to you for the risk assessment. Purely from a devtools POV it seems safe, but if you're concerned about non-devtools side effects, I understand if we prefer to wait.

Comment 12

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 9301593 [details]
Bug 1798483 - Improve behavior of devtools splitting to prevent overflow. r=jdescottes

Beta/Release Uplift Approval Request

• User impact if declined: comment 0, see last comment too
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: comment 0
• List of other uplifts needed: none
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Relatively straight-forward CSS changes. Depends on bug 1794630, but the relevant parts of that work are in 107 already.
• String changes made/needed: none
• Is Android affected?: No

Comment 13

[Donal Meehan [:dmeehan]]

Comment on attachment 9301593 [details]
Bug 1798483 - Improve behavior of devtools splitting to prevent overflow. r=jdescottes

Approved for 107.0b9

Comment 14

[Donal Meehan [:dmeehan]]

https://hg.mozilla.org/releases/mozilla-beta/rev/6890b5b32eec

Comment 15

[Alin Ilea, Desktop QA]

Reproduced the issue in Beta 107.0b8 using Windows 10.
Verified - Fixed in Beta 107.0b9 and the latest Nightly 108.0a1 (build id: 20221103214316), using Windows 10, macOS 12 and Ubuntu 20.