Closed Bug 1798561 Opened 2 years ago Closed 7 months ago

Special Message Action SHOW_MIGRATION_WIZARD handling should wait for migrate dialog to close

Categories

(Firefox :: Messaging System, enhancement)

enhancement

Tracking

()

RESOLVED WONTFIX

People

(Reporter: pdahiya, Unassigned)

References

(Blocks 1 open bug)

Details

D157947 refactored SMA SHOW_MIGRATION_WIZARD handling call to be asynchronous for Windows and Linux platform.

However with possibility of SHOW_MIGRATION_WIZARD as one of action in MULTI_ACTION, we do need a reliable way in onboarding to wait for Import Wizard migration to finish before navigating to next screen. This needs SHOW_MIGRATION_WIZARD handler to be a promise or add a call similar to AWWaitForMigrationClose to allow wait in the handler before returning

https://searchfox.org/mozilla-central/rev/a3decf626dabd89620171f0ea7840cc4351fe218/browser/components/newtab/content-src/aboutwelcome/components/MultiStageAboutWelcome.jsx#322

https://phabricator.services.mozilla.com/D157947
https://phabricator.services.mozilla.com/D160861

Summary: Special Message Action SHOW_MIGRATION_WIZARD handling should be synchronous → Special Message Action SHOW_MIGRATION_WIZARD handling should wait for migrate dialog to close
See Also: → 1798341, 1792014

I can tackle this one if you're not already working on it Punam?

Assignee: nobody → shughes
Status: NEW → ASSIGNED

(In reply to Shane Hughes [:aminomancer] from comment #1)

I can tackle this one if you're not already working on it Punam?

Please go for it, thank you!

Priority: -- → P2
Assignee: shughes → nobody
Status: ASSIGNED → NEW
Priority: P2 → --
Flags: needinfo?(pdahiya)

With Embedded Import wizard as default experience in Fx117 for both about:welcome and spotlight, we no longer open Import Wizard inside Modal which was needing this explicit await before execution return to opener and safe to close as WONT FIX

Status: NEW → RESOLVED
Closed: 7 months ago
Flags: needinfo?(pdahiya)
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.