Closed Bug 1798574 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 36769 - Allow CSS toggles to apply to elements with default behavior.

Categories

(Core :: CSS Parsing and Computation, task, P4)

Product:
Core
Component:
CSS Parsing and Computation
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
108 Branch
Tracking Flags:
Tracking Status
firefox108 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 36769 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/36769
Details from upstream follow.

L. David Baron <dbaron@chromium.org> wrote:

Allow CSS toggles to apply to elements with default behavior.

This lets the toggle-trigger property cause activation of CSS toggles on
elements with default behavior, but continues to not activate the toggle
if the event is from a descendant with default behavior.

Support for toggles is controlled by the CSSToggles flag (currently off)
in RuntimeEnabledFeatures.

Bug: 1250716
Change-Id: I61b502bd54d39cd5f57f35603d41fe1eee8fab03
Reviewed-on: https://chromium-review.googlesource.com/3996338
WPT-Export-Revision: 0854d5ac3e0c61132020f73b0b8b0228588b8314

Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core

CI Results

Ran 10 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 113 subtests

Status Summary

Firefox

OK : 1
FAIL: 113

Chrome

OK : 1
FAIL: 113

Safari

OK : 1
FAIL: 113

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

  • /css/css-toggle/toggle-activation.tentative.html [wpt.fyi]
    • finding toggle: wide toggle on previous sibling: FAIL (Chrome: FAIL, Safari: FAIL)
    • finding toggle: narrow toggle on previous sibling: FAIL (Chrome: FAIL, Safari: FAIL)
    • finding toggle: wide toggle on previous sibling with intervening narrow toggle: FAIL (Chrome: FAIL, Safari: FAIL)
    • finding toggle: wide toggle on parent with intervening narrow toggle: FAIL (Chrome: FAIL, Safari: FAIL)
    • finding toggle: wide toggle on parent's prior sibling with intervening narrow toggle: FAIL (Chrome: FAIL, Safari: FAIL)
    • finding toggle: wide toggle on later sibling: FAIL (Chrome: FAIL, Safari: FAIL)
    • finding toggle: wide toggle on child: FAIL (Chrome: FAIL, Safari: FAIL)
    • states used from toggle or toggle specifier as appropriate (integer): FAIL (Chrome: FAIL, Safari: FAIL)
    • states used from toggle or toggle specifier as appropriate (names): FAIL (Chrome: FAIL, Safari: FAIL)
    • group used from toggle or toggle specifier as appropriate: FAIL (Chrome: FAIL, Safari: FAIL)
    • overflow used from toggle or toggle specifier as appropriate: FAIL (Chrome: FAIL, Safari: FAIL)
    • changing with toggle-trigger: set (numbers): FAIL (Chrome: FAIL, Safari: FAIL)
    • changing with toggle-trigger: set (named states): FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "2" changing from "0" with action "next": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "2 cycle" changing from "0" with action "next": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "2 cycle-on" changing from "0" with action "next": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "2 sticky" changing from "0" with action "next": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "2" changing from "1" with action "next": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "2 cycle" changing from "1" with action "next": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "2 cycle-on" changing from "1" with action "next": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "2 sticky" changing from "1" with action "next": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "2" changing from "2" with action "next": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "2 cycle" changing from "2" with action "next": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "2 cycle-on" changing from "2" with action "next": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "2 sticky" changing from "2" with action "next": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "3" changing from "5" with action "next": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "3 cycle" changing from "5" with action "next": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "3 cycle-on" changing from "5" with action "next": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "3 sticky" changing from "5" with action "next": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "4" changing from "3" with action "next": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "4 cycle" changing from "3" with action "next": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "4 cycle-on" changing from "3" with action "next": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "4 sticky" changing from "3" with action "next": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "4" changing from "3" with action "next 3": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "4 cycle" changing from "3" with action "next 3": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "4 cycle-on" changing from "3" with action "next 3": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "4 sticky" changing from "3" with action "next 3": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "3" changing from "named-value" with action "next": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "3 cycle" changing from "named-value" with action "next": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "3 cycle-on" changing from "named-value" with action "next": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "3 sticky" changing from "named-value" with action "next": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "[a b c d]" changing from "a" with action "next": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "[a b c d] cycle" changing from "a" with action "next": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "[a b c d] cycle-on" changing from "a" with action "next": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "[a b c d] sticky" changing from "a" with action "next": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "[a b c d]" changing from "a" with action "next 5": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "[a b c d] cycle" changing from "a" with action "next 5": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "[a b c d] cycle-on" changing from "a" with action "next 5": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "[a b c d] sticky" changing from "a" with action "next 5": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "[a b c d]" changing from "c" with action "next": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "[a b c d] cycle" changing from "c" with action "next": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "[a b c d] cycle-on" changing from "c" with action "next": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "[a b c d] sticky" changing from "c" with action "next": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "[a b c d]" changing from "d" with action "next": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "[a b c d] cycle" changing from "d" with action "next": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "[a b c d] cycle-on" changing from "d" with action "next": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "[a b c d] sticky" changing from "d" with action "next": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "[a b c d]" changing from "extra-state" with action "next": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "[a b c d] cycle" changing from "extra-state" with action "next": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "[a b c d] cycle-on" changing from "extra-state" with action "next": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "[a b c d] sticky" changing from "extra-state" with action "next": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "2" changing from "0" with action "prev": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "2 cycle" changing from "0" with action "prev": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "2 cycle-on" changing from "0" with action "prev": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "2 sticky" changing from "0" with action "prev": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "2" changing from "1" with action "prev": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "2 cycle" changing from "1" with action "prev": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "2 cycle-on" changing from "1" with action "prev": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "2 sticky" changing from "1" with action "prev": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "2" changing from "2" with action "prev": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "2 cycle" changing from "2" with action "prev": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "2 cycle-on" changing from "2" with action "prev": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "2 sticky" changing from "2" with action "prev": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "2" changing from "5" with action "prev": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "2 cycle" changing from "5" with action "prev": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "2 cycle-on" changing from "5" with action "prev": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "2 sticky" changing from "5" with action "prev": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "3" changing from "5" with action "prev 3": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "3 cycle" changing from "5" with action "prev 3": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "3 cycle-on" changing from "5" with action "prev 3": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "3 sticky" changing from "5" with action "prev 3": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "3" changing from "2" with action "prev 3": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "3 cycle" changing from "2" with action "prev 3": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "3 cycle-on" changing from "2" with action "prev 3": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "3 sticky" changing from "2" with action "prev 3": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "3" changing from "named-value" with action "prev": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "3 cycle" changing from "named-value" with action "prev": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "3 cycle-on" changing from "named-value" with action "prev": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "3 sticky" changing from "named-value" with action "prev": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "[a b c d]" changing from "a" with action "prev": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "[a b c d] cycle" changing from "a" with action "prev": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "[a b c d] cycle-on" changing from "a" with action "prev": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "[a b c d] sticky" changing from "a" with action "prev": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "[a b c d]" changing from "b" with action "prev": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "[a b c d] cycle" changing from "b" with action "prev": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "[a b c d] cycle-on" changing from "b" with action "prev": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "[a b c d] sticky" changing from "b" with action "prev": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "[a b c d]" changing from "d" with action "prev": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "[a b c d] cycle" changing from "d" with action "prev": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "[a b c d] cycle-on" changing from "d" with action "prev": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "[a b c d] sticky" changing from "d" with action "prev": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "[a b c d]" changing from "c" with action "prev 5": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "[a b c d] cycle" changing from "c" with action "prev 5": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "[a b c d] cycle-on" changing from "c" with action "prev 5": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "[a b c d] sticky" changing from "c" with action "prev 5": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "[a b c d]" changing from "extra-state" with action "prev": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "[a b c d] cycle" changing from "extra-state" with action "prev": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "[a b c d] cycle-on" changing from "extra-state" with action "prev": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle with "[a b c d] sticky" changing from "extra-state" with action "prev": FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle activation on button with toggle-trigger (1): FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle activation on button with toggle-trigger (2): FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle activation on button inside element with toggle-trigger: FAIL (Chrome: FAIL, Safari: FAIL)
    • toggle activation on div inside element with toggle-trigger: FAIL (Chrome: FAIL, Safari: FAIL)
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b75ae6a8a08d [wpt PR 36769] - Allow CSS toggles to apply to elements with default behavior., a=testonly https://hg.mozilla.org/integration/autoland/rev/86df451cebb4 [wpt PR 36769] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/b75ae6a8a08d
https://hg.mozilla.org/mozilla-central/rev/86df451cebb4

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox108: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 108 Branch
You need to log in before you can comment on or make changes to this bug.