Closed
Bug 1798692
Opened 2 years ago
Closed 2 years ago
Time in Tab Pickup list tabs stuck on "Just now"
Categories
(Firefox :: Firefox View, defect, P1)
Firefox
Firefox View
Tracking
()
VERIFIED
FIXED
108 Branch
| Tracking | Status | |
|---|---|---|
| firefox-esr102 | --- | unaffected |
| firefox106 | --- | unaffected |
| firefox107 | --- | unaffected |
| firefox108 | --- | verified |
People
(Reporter: sclements, Assigned: sclements)
References
(Regression)
Details
(Keywords: regression, Whiteboard: [fidefe-2022-mr1-firefox-view] )
Attachments
(1 file)
It looks like the format of the lastUsed timestamp has changed and we no longer need to multiply the value by 1000 per here: https://searchfox.org/mozilla-central/source/browser/components/firefoxview/tab-pickup-list.mjs#294
It looks like it was regressed by a change here, which was previously Math.floor((tab.lastAccessed || 0) / 1000).
It's an easy fix though, so I'll just submit a patch since I've already looked into the cause and solution.
|
||
Updated•2 years ago
|
Priority: -- → P1
|
|
||
Comment 1•2 years ago
|
||
Just assigning this a priority since you're going to fix it now.
|
Assignee | |
Comment 2•2 years ago
|
||
- Remove multiplication of lastUsed by 1000 due to changes in bug 1791851
|
|
Assignee | |
Updated•2 years ago
|
Status: NEW → ASSIGNED
|
|
Assignee | |
Updated•2 years ago
|
Whiteboard: [fidefe-2022-mr1-firefox-view]
|
||
Updated•2 years ago
|
Keywords: regression
|
|
||
Comment 3•2 years ago
|
||
Set release status flags based on info from the regressing bug 1791851
status-firefox106:
--- → unaffected
status-firefox107:
--- → unaffected
status-firefox108:
--- → affected
status-firefox-esr102:
--- → unaffected
|
||
Updated•2 years ago
|
Severity: -- → S3
|
||
Updated•2 years ago
|
Pushed by sclements@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/45d622a21042 Fix timestamp used in Tab Pickup list r=sfoster
|
||
Comment 5•2 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 108 Branch
|
|
||
Comment 6•2 years ago
|
||
Hello,
This is verified as fixed using Nightly 108.0a1 (2022-11-03) on Windows 10, macOS 10.14.6 and Ubuntu 22.04. The time in tab pickup is correctly adjusted.
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•