1798703 - 21.55 - 8.48% motionmark_webgl 3DGraphics-WebGL / motionmark_webgl 3DGraphics-WebGL + 8 more (Linux, OSX, Windows) regression on Wed October 26 2022

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect)

Description

[Andrej (:aglavic)]

Perfherder has detected a talos performance regression from push 4bf6c23773ea84292963011072112dec90c22100. As author of one of the patches included in that push, we need your help to address this regression.

Regressions:

Ratio	Test	Platform	Options	Absolute values (old vs new)
22%	motionmark_webgl 3DGraphics-WebGL	linux1804-64-qr	e10s fission stylo webgl-ipc webrender	11.41 -> 8.95
19%	motionmark_webgl 3DGraphics-WebGL	macosx1015-64-shippable-qr	e10s fission stylo webrender	16.10 -> 13.10
17%	motionmark_webgl 3DGraphics-WebGL	linux1804-64-shippable-qr	e10s fission stylo webrender	10.34 -> 8.63
15%	motionmark_webgl 3DGraphics-WebGL	macosx1015-64-shippable-qr	e10s fission stylo webrender-sw	15.89 -> 13.44
15%	motionmark_webgl 3DGraphics-WebGL	macosx1015-64-shippable-qr	e10s fission stylo webrender-sw	15.65 -> 13.24
12%	motionmark_webgl 3DGraphics-WebGL	windows10-64-ref-hw-2017-qr	e10s fission stylo webgl-ipc webrender	7.23 -> 6.35
10%	motionmark_webgl 3DGraphics-WebGL	windows10-64-shippable-qr	e10s fission stylo webrender-sw	10.84 -> 9.80
10%	motionmark_webgl 3DGraphics-WebGL	windows10-64-shippable-qr	e10s fission stylo webrender	10.84 -> 9.81
9%	motionmark_webgl 3DGraphics-WebGL	windows10-64-shippable-qr	e10s fission stylo webgl-ipc webrender	10.73 -> 9.78
8%	motionmark_webgl 3DGraphics-WebGL	windows10-64-shippable-qr	e10s fission stylo webrender-sw	10.74 -> 9.83

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests. Please follow our guide to handling regression bugs and let us know your plans within 3 business days, or the offending patch(es) may be backed out in accordance with our regression policy.

If you need the profiling jobs you can trigger them yourself from treeherder job view or ask a sheriff to do that for you.

For more information on performance sheriffing please see our FAQ.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1794237

Comment 2

[Lee Salzman [:lsalzman]]

We're working on a fix for this.

Comment 3

[Kelsey Gilbert [:jgilbert]]

Attachment: Bug 1798703 - Enforce alignment for UniformData via union rather than overalignment.

Reverts the overalignment from bug 1794237.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/88e894153e58
Enforce alignment for UniformData via union rather than overalignment. r=lsalzman

Comment 5

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/88e894153e58

Comment 6

[Kelsey Gilbert [:jgilbert]]

It does look like we might have done better than fixing the regression, even: https://treeherder.mozilla.org/perfherder/graphs?highlightAlerts=1&highlightChangelogData=1&highlightCommonAlerts=0&series=mozilla-central,4139475,1,1&series=mozilla-central,4101610,1,1&timerange=1209600

I didn't really expect it to be better than before, but I did retrigger so we can wait and see if it's just noise.

Comment 7

[Kelsey Gilbert [:jgilbert]]

Oops, I think I didn't reach backwards in time enough. Yes, it looks like a return to pre-regression.

Comment 8

[Andrej (:aglavic)]

== Change summary for alert #36033 (as of Thu, 10 Nov 2022 21:56:58 GMT) ==

Improvements:

Ratio	Test	Platform	Options	Absolute values (old vs new)
22%	motionmark_webgl 3DGraphics-WebGL	linux1804-64-qr	e10s fission stylo webgl-ipc webrender	8.81 -> 10.72
22%	motionmark_webgl 3DGraphics-WebGL	linux1804-64-shippable-qr	e10s fission stylo webrender	8.22 -> 9.99
19%	motionmark_webgl 3DGraphics-WebGL	linux1804-64-shippable-qr	e10s fission stylo webgl-ipc webrender	8.32 -> 9.92
19%	motionmark_webgl 3DGraphics-WebGL	macosx1015-64-shippable-qr	e10s fission stylo webrender-sw	13.22 -> 15.72
19%	motionmark_webgl 3DGraphics-WebGL	macosx1015-64-shippable-qr	e10s fission stylo webrender	13.33 -> 15.84
...	...	...	...	...
9%	motionmark_webgl 3DGraphics-WebGL	windows10-64-ref-hw-2017-qr	e10s fission stylo webgl-ipc webrender	7.06 -> 7.69

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=36033