Closed Bug 1798760 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 36785 - FSA: Use strict JS in all WPT script files

Tracking

(firefox108 fixed)

Status:

RESOLVED FIXED

Milestone:

108 Branch

Tracking Flags:

Tracking

Status

firefox108

---

fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)

Assignee

Description

•

3 years ago

Sync web-platform-tests PR 36785 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/36785
Details from upstream follow.

Austin Sullivan <asully@chromium.org> wrote:

FSA: Use strict JS in all WPT script files

'use strict' is currently inconsistently used across the various FS
WPTs.

Change-Id: I9f132055ced6c5023beea5b421935e046144d82c
Reviewed-on: https://chromium-review.googlesource.com/3999251
WPT-Export-Revision: 661d15faad33effcb1dea34369be4e180f765797

Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)

Assignee

Comment 1

•

3 years ago

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=acbe011dd19ef9a81195d54f37d215a9864d296d

Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)

Assignee

Comment 2

•

3 years ago

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 16 tests and 10 subtests

Status Summary

Firefox

OK : 16
FAIL: 156

Chrome

OK : 16
PASS: 154
FAIL: 2

Safari

OK : 16
FAIL: 156

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/fs/FileSystemDirectoryHandle-getDirectoryHandle.https.any.html [wpt.fyi]
- getDirectoryHandle(create=false) rejects for non-existing directories: FAIL (Chrome: PASS, Safari: FAIL)
- getDirectoryHandle(create=true) creates an empty directory: FAIL (Chrome: PASS, Safari: FAIL)
- getDirectoryHandle(create=false) returns existing directories: FAIL (Chrome: PASS, Safari: FAIL)
- getDirectoryHandle(create=true) returns existing directories without erasing: FAIL (Chrome: PASS, Safari: FAIL)
- getDirectoryHandle() when a file already exists with the same name: FAIL (Chrome: PASS, Safari: FAIL)
- getDirectoryHandle() with empty name: FAIL (Chrome: PASS, Safari: FAIL)
- getDirectoryHandle() with "." name: FAIL (Chrome: PASS, Safari: FAIL)
- getDirectoryHandle() with ".." name: FAIL (Chrome: PASS, Safari: FAIL)
- getDirectoryHandle(create=false) with a path separator when the directory exists: FAIL (Chrome: PASS, Safari: FAIL)
- getDirectoryHandle(create=true) with a path separator: FAIL (Chrome: PASS, Safari: FAIL)
/fs/FileSystemDirectoryHandle-getDirectoryHandle.https.any.worker.html [wpt.fyi]
- getDirectoryHandle(create=false) rejects for non-existing directories: FAIL (Chrome: PASS, Safari: FAIL)
- getDirectoryHandle(create=true) creates an empty directory: FAIL (Chrome: PASS, Safari: FAIL)
- getDirectoryHandle(create=false) returns existing directories: FAIL (Chrome: PASS, Safari: FAIL)
- getDirectoryHandle(create=true) returns existing directories without erasing: FAIL (Chrome: PASS, Safari: FAIL)
- getDirectoryHandle() when a file already exists with the same name: FAIL (Chrome: PASS, Safari: FAIL)
- getDirectoryHandle() with empty name: FAIL (Chrome: PASS, Safari: FAIL)
- getDirectoryHandle() with "." name: FAIL (Chrome: PASS, Safari: FAIL)
- getDirectoryHandle() with ".." name: FAIL (Chrome: PASS, Safari: FAIL)
- getDirectoryHandle(create=false) with a path separator when the directory exists: FAIL (Chrome: PASS, Safari: FAIL)
- getDirectoryHandle(create=true) with a path separator: FAIL (Chrome: PASS, Safari: FAIL)
/fs/FileSystemDirectoryHandle-getFileHandle.https.any.html [wpt.fyi]
- getFileHandle(create=false) rejects for non-existing files: FAIL (Chrome: PASS, Safari: FAIL)
- getFileHandle(create=true) creates an empty file for non-existing files: FAIL (Chrome: PASS, Safari: FAIL)
- getFileHandle(create=false) returns existing files: FAIL (Chrome: PASS, Safari: FAIL)
- getFileHandle(create=true) returns existing files without erasing: FAIL (Chrome: PASS, Safari: FAIL)
- getFileHandle(create=false) when a directory already exists with the same name: FAIL (Chrome: PASS, Safari: FAIL)
- getFileHandle(create=true) when a directory already exists with the same name: FAIL (Chrome: PASS, Safari: FAIL)
- getFileHandle() with empty name: FAIL (Chrome: PASS, Safari: FAIL)
- getFileHandle() with "." name: FAIL (Chrome: PASS, Safari: FAIL)
- getFileHandle() with ".." name: FAIL (Chrome: PASS, Safari: FAIL)
- getFileHandle(create=false) with a path separator when the file exists.: FAIL (Chrome: PASS, Safari: FAIL)
- getFileHandle(create=true) with a path separator: FAIL (Chrome: PASS, Safari: FAIL)
/fs/FileSystemDirectoryHandle-getFileHandle.https.any.worker.html [wpt.fyi]
- getFileHandle(create=false) rejects for non-existing files: FAIL (Chrome: PASS, Safari: FAIL)
- getFileHandle(create=true) creates an empty file for non-existing files: FAIL (Chrome: PASS, Safari: FAIL)
- getFileHandle(create=false) returns existing files: FAIL (Chrome: PASS, Safari: FAIL)
- getFileHandle(create=true) returns existing files without erasing: FAIL (Chrome: PASS, Safari: FAIL)
- getFileHandle(create=false) when a directory already exists with the same name: FAIL (Chrome: PASS, Safari: FAIL)
- getFileHandle(create=true) when a directory already exists with the same name: FAIL (Chrome: PASS, Safari: FAIL)
- getFileHandle() with empty name: FAIL (Chrome: PASS, Safari: FAIL)
- getFileHandle() with "." name: FAIL (Chrome: PASS, Safari: FAIL)
- getFileHandle() with ".." name: FAIL (Chrome: PASS, Safari: FAIL)
- getFileHandle(create=false) with a path separator when the file exists.: FAIL (Chrome: PASS, Safari: FAIL)
- getFileHandle(create=true) with a path separator: FAIL (Chrome: PASS, Safari: FAIL)
/fs/FileSystemDirectoryHandle-iteration.https.any.html [wpt.fyi]
- returning early from an iteration doesn't crash: FAIL (Chrome: PASS, Safari: FAIL)
- @@asyncIterator: full iteration works: FAIL (Chrome: PASS, Safari: FAIL)
- entries: full iteration works: FAIL (Chrome: PASS, Safari: FAIL)
- values: full iteration works: FAIL (Chrome: PASS, Safari: FAIL)
- keys: full iteration works: FAIL (Chrome: PASS, Safari: FAIL)
- iteration while iterator gets garbage collected: FAIL (Chrome: PASS, Safari: FAIL)
/fs/FileSystemDirectoryHandle-iteration.https.any.worker.html [wpt.fyi]
- returning early from an iteration doesn't crash: FAIL (Chrome: PASS, Safari: FAIL)
- @@asyncIterator: full iteration works: FAIL (Chrome: PASS, Safari: FAIL)
- entries: full iteration works: FAIL (Chrome: PASS, Safari: FAIL)
- values: full iteration works: FAIL (Chrome: PASS, Safari: FAIL)
- keys: full iteration works: FAIL (Chrome: PASS, Safari: FAIL)
- iteration while iterator gets garbage collected: FAIL (Chrome: PASS, Safari: FAIL)
/fs/FileSystemDirectoryHandle-removeEntry.https.any.html [wpt.fyi]
- removeEntry() while the file has an open writable fails: FAIL (Chrome: FAIL, Safari: FAIL)
/fs/FileSystemDirectoryHandle-removeEntry.https.any.worker.html [wpt.fyi]
- removeEntry() while the file has an open writable fails: FAIL (Chrome: FAIL, Safari: FAIL)
/fs/FileSystemFileHandle-getFile.https.any.html [wpt.fyi]
- getFile() provides a file that can be sliced: FAIL (Chrome: PASS, Safari: FAIL)
- getFile() returns last modified time: FAIL (Chrome: PASS, Safari: FAIL)
/fs/FileSystemFileHandle-getFile.https.any.worker.html [wpt.fyi]
- getFile() provides a file that can be sliced: FAIL (Chrome: PASS, Safari: FAIL)
- getFile() returns last modified time: FAIL (Chrome: PASS, Safari: FAIL)
/fs/FileSystemWritableFileStream-piped.https.any.html [wpt.fyi]
- can be piped to with a string: FAIL (Chrome: PASS, Safari: FAIL)
- can be piped to with an ArrayBuffer: FAIL (Chrome: PASS, Safari: FAIL)
- can be piped to with a Blob: FAIL (Chrome: PASS, Safari: FAIL)
- can be piped to with a param object with write command: FAIL (Chrome: PASS, Safari: FAIL)
- can be piped to with a param object with multiple commands: FAIL (Chrome: PASS, Safari: FAIL)
- multiple operations can be queued: FAIL (Chrome: PASS, Safari: FAIL)
- plays well with fetch: FAIL (Chrome: PASS, Safari: FAIL)
- abort() aborts write: FAIL (Chrome: PASS, Safari: FAIL)
/fs/FileSystemWritableFileStream-piped.https.any.worker.html [wpt.fyi]
- can be piped to with a string: FAIL (Chrome: PASS, Safari: FAIL)
- can be piped to with an ArrayBuffer: FAIL (Chrome: PASS, Safari: FAIL)
- can be piped to with a Blob: FAIL (Chrome: PASS, Safari: FAIL)
- can be piped to with a param object with write command: FAIL (Chrome: PASS, Safari: FAIL)
- can be piped to with a param object with multiple commands: FAIL (Chrome: PASS, Safari: FAIL)
- multiple operations can be queued: FAIL (Chrome: PASS, Safari: FAIL)
- plays well with fetch: FAIL (Chrome: PASS, Safari: FAIL)
- abort() aborts write: FAIL (Chrome: PASS, Safari: FAIL)
/fs/FileSystemWritableFileStream-write.https.any.html [wpt.fyi]
- write() with an empty blob to an empty file: FAIL (Chrome: PASS, Safari: FAIL)
- write() a blob to an empty file: FAIL (Chrome: PASS, Safari: FAIL)
- write() with WriteParams without position to an empty file: FAIL (Chrome: PASS, Safari: FAIL)
- write() a string to an empty file with zero offset: FAIL (Chrome: PASS, Safari: FAIL)
- write() a blob to an empty file with zero offset: FAIL (Chrome: PASS, Safari: FAIL)
- write() called consecutively appends: FAIL (Chrome: PASS, Safari: FAIL)
- write() WriteParams without position and string appends: FAIL (Chrome: PASS, Safari: FAIL)
- write() WriteParams without position and blob appends: FAIL (Chrome: PASS, Safari: FAIL)
- write() called with a string and a valid offset: FAIL (Chrome: PASS, Safari: FAIL)
- write() called with a blob and a valid offset: FAIL (Chrome: PASS, Safari: FAIL)
- write() called with an offset beyond the end of the file: FAIL (Chrome: PASS, Safari: FAIL)
- write() with an empty string to an empty file: FAIL (Chrome: PASS, Safari: FAIL)
- write() with a valid utf-8 string: FAIL (Chrome: PASS, Safari: FAIL)
- write() with a string with unix line ending preserved: FAIL (Chrome: PASS, Safari: FAIL)
- write() with a string with windows line ending preserved: FAIL (Chrome: PASS, Safari: FAIL)
- write() with an empty array buffer to an empty file: FAIL (Chrome: PASS, Safari: FAIL)
- write() with a valid typed array buffer: FAIL (Chrome: PASS, Safari: FAIL)
- atomic writes: close() fails when parent directory is removed: FAIL (Chrome: PASS, Safari: FAIL)
- atomic writes: writable file streams make atomic changes on close: FAIL (Chrome: PASS, Safari: FAIL)
- atomic writes: write() after close() fails: FAIL (Chrome: PASS, Safari: FAIL)
- atomic writes: truncate() after close() fails: FAIL (Chrome: PASS, Safari: FAIL)
- atomic writes: close() after close() fails: FAIL (Chrome: PASS, Safari: FAIL)
- atomic writes: only one close() operation may succeed: FAIL (Chrome: PASS, Safari: FAIL)
- atomic writes: writable file stream persists file on close, even if file is removed: FAIL (Chrome: PASS, Safari: FAIL)
- getWriter() can be used: FAIL (Chrome: PASS, Safari: FAIL)
- WriteParams: truncate missing size param: FAIL (Chrome: PASS, Safari: FAIL)
- WriteParams: write missing data param: FAIL (Chrome: PASS, Safari: FAIL)
- WriteParams: write null data param: FAIL (Chrome: PASS, Safari: FAIL)
- WriteParams: seek missing position param: FAIL (Chrome: PASS, Safari: FAIL)
- write() with an invalid blob to an empty file should reject: FAIL (Chrome: PASS, Safari: FAIL)
/fs/FileSystemWritableFileStream-write.https.any.worker.html [wpt.fyi]
- write() with an empty blob to an empty file: FAIL (Chrome: PASS, Safari: FAIL)
- write() a blob to an empty file: FAIL (Chrome: PASS, Safari: FAIL)
- write() with WriteParams without position to an empty file: FAIL (Chrome: PASS, Safari: FAIL)
- write() a string to an empty file with zero offset: FAIL (Chrome: PASS, Safari: FAIL)
- write() a blob to an empty file with zero offset: FAIL (Chrome: PASS, Safari: FAIL)
- write() called consecutively appends: FAIL (Chrome: PASS, Safari: FAIL)
- write() WriteParams without position and string appends: FAIL (Chrome: PASS, Safari: FAIL)
- write() WriteParams without position and blob appends: FAIL (Chrome: PASS, Safari: FAIL)
- write() called with a string and a valid offset: FAIL (Chrome: PASS, Safari: FAIL)
- write() called with a blob and a valid offset: FAIL (Chrome: PASS, Safari: FAIL)
- write() called with an offset beyond the end of the file: FAIL (Chrome: PASS, Safari: FAIL)
- write() with an empty string to an empty file: FAIL (Chrome: PASS, Safari: FAIL)
- write() with a valid utf-8 string: FAIL (Chrome: PASS, Safari: FAIL)
- write() with a string with unix line ending preserved: FAIL (Chrome: PASS, Safari: FAIL)
- write() with a string with windows line ending preserved: FAIL (Chrome: PASS, Safari: FAIL)
- write() with an empty array buffer to an empty file: FAIL (Chrome: PASS, Safari: FAIL)
- write() with a valid typed array buffer: FAIL (Chrome: PASS, Safari: FAIL)
- atomic writes: close() fails when parent directory is removed: FAIL (Chrome: PASS, Safari: FAIL)
- atomic writes: writable file streams make atomic changes on close: FAIL (Chrome: PASS, Safari: FAIL)
- atomic writes: write() after close() fails: FAIL (Chrome: PASS, Safari: FAIL)
- atomic writes: truncate() after close() fails: FAIL (Chrome: PASS, Safari: FAIL)
- atomic writes: close() after close() fails: FAIL (Chrome: PASS, Safari: FAIL)
- atomic writes: only one close() operation may succeed: FAIL (Chrome: PASS, Safari: FAIL)
- atomic writes: writable file stream persists file on close, even if file is removed: FAIL (Chrome: PASS, Safari: FAIL)
- getWriter() can be used: FAIL (Chrome: PASS, Safari: FAIL)
- WriteParams: truncate missing size param: FAIL (Chrome: PASS, Safari: FAIL)
- WriteParams: write missing data param: FAIL (Chrome: PASS, Safari: FAIL)
- WriteParams: write null data param: FAIL (Chrome: PASS, Safari: FAIL)
- WriteParams: seek missing position param: FAIL (Chrome: PASS, Safari: FAIL)
- write() with an invalid blob to an empty file should reject: FAIL (Chrome: PASS, Safari: FAIL)
/fs/FileSystemWritableFileStream.https.any.worker.html [wpt.fyi]
- truncate() to shrink a file: FAIL (Chrome: PASS, Safari: FAIL)
- truncate() to grow a file: FAIL (Chrome: PASS, Safari: FAIL)
- createWritable() fails when parent directory is removed: FAIL (Chrome: PASS, Safari: FAIL)
- write() fails when parent directory is removed: FAIL (Chrome: PASS, Safari: FAIL)
- truncate() fails when parent directory is removed: FAIL (Chrome: PASS, Safari: FAIL)
- createWritable({keepExistingData: true}): atomic writable file stream initialized with source contents: FAIL (Chrome: PASS, Safari: FAIL)
- createWritable({keepExistingData: false}): atomic writable file stream initialized with empty file: FAIL (Chrome: PASS, Safari: FAIL)
- cursor position: truncate size > offset: FAIL (Chrome: PASS, Safari: FAIL)
- cursor position: truncate size < offset: FAIL (Chrome: PASS, Safari: FAIL)
- commands are queued, stream is unlocked after each operation: FAIL (Chrome: PASS, Safari: FAIL)
/fs/FileSystemWritableFileStream.https.any.html [wpt.fyi]
- truncate() to shrink a file: FAIL (Chrome: PASS, Safari: FAIL)
- truncate() to grow a file: FAIL (Chrome: PASS, Safari: FAIL)
- createWritable() fails when parent directory is removed: FAIL (Chrome: PASS, Safari: FAIL)
- write() fails when parent directory is removed: FAIL (Chrome: PASS, Safari: FAIL)
- truncate() fails when parent directory is removed: FAIL (Chrome: PASS, Safari: FAIL)
- createWritable({keepExistingData: true}): atomic writable file stream initialized with source contents: FAIL (Chrome: PASS, Safari: FAIL)
- createWritable({keepExistingData: false}): atomic writable file stream initialized with empty file: FAIL (Chrome: PASS, Safari: FAIL)
- cursor position: truncate size > offset: FAIL (Chrome: PASS, Safari: FAIL)
- cursor position: truncate size < offset: FAIL (Chrome: PASS, Safari: FAIL)
- commands are queued, stream is unlocked after each operation: FAIL (Chrome: PASS, Safari: FAIL)

Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)

Assignee

Updated

•

3 years ago

Depends on: 1800089

Pulsebot

Comment 3

•

3 years ago

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/89c05defca9f [wpt PR 36785] - FSA: Use strict JS in all WPT script files, a=testonly

Natalia Csoregi [:nataliaCs]

Comment 4

•

3 years ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/89c05defca9f

Status: NEW → RESOLVED

Closed: 3 years ago

status-firefox108: --- → fixed

Resolution: --- → FIXED

Target Milestone: --- → 108 Branch

You need to log in before you can comment on or make changes to this bug.

Bugzilla

[wpt-sync] Sync PR 36785 - FSA: Use strict JS in all WPT script files

Categories

(Testing :: web-platform-tests, task, P4)

Tracking

(firefox108 fixed)

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Crash Data

Security

(public)

User Story

Description

Comment 1

Comment 2

CI Results

Status Summary

Firefox

Chrome

Safari

Links

Details

New Tests That Don't Pass

Updated

Comment 3

Comment 4