179892 - Installer exits with no error after unpacking files - problem with TMP environment var

Status: RESOLVED WORKSFORME

(SeaMonkey :: Installer, defect)

Description

[Erik Corry]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:0.9.9) Gecko/20020311
Build Identifier: mozilla-win32-1.2b-installer.exe

If you have an envionment variable with a space in a directory component and
there is also a file called the same name as the first word in the directory
component, then the installer just drops dead with no information about why. 
This is a longstanding bug.

Reproducible: Always

Steps to Reproduce:
1. mkdir "c:\temporary directory"
2. set TMP=c:\temporary directory
3. create file called c:\temporary (it is important that this is a file, not a dir)
4. Run installer

Actual Results:  
Files are unpacked, then program exits

Expected Results:  
Install Mozilla

Comment 1

[Henrik Gemal]

yeps thats true. We should at least warn that there's an error unpacking files!

Comment 2

[Henrik Gemal]

the installer actually gets unpacking into "C:\temporary dir\ns_temp\" but it
seem s to be the launching of the setup.exe file from within that dir that is
the problem.

Comment 3

[Henrik Gemal]

just create a file called "ns_temp" in your %TEMP directory and you're unable to
launch the installer. It just quits

Sean: Do we need to quote something to get this working?

Is it correct that setup.exe is launched from:
http://lxr.mozilla.org/mozilla/source/xpinstall/wizard/windows/nsinstall/nsinstall.cpp#892
?

Comment 4

[Henrik Gemal]

having a file called "ns_temp" is actually another bug since nothings gets
unpacked or anything.

Comment 5

[Sean Su]

Henrik, that's correct.  That is where it gets launched from.

Comment 6

[K'Trina Medina]

*** Bug 183228 has been marked as a duplicate of this bug. ***

Comment 7

[Matthias Versen [:Matti]]

Seamonkey and Firefox are using a new NSIS based installer. resolving this old
bug, please reopen if you still get this with the new installer