Closed Bug 1798948 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 36801 - Don't propagate early-breaks that would end up in parallel flows.

Categories

(Core :: Layout, task, P4)

Product:
Core
Component:
Layout
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
108 Branch
Tracking Flags:
Tracking Status
firefox108 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 36801 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/36801
Details from upstream follow.

Morten Stenshorne <mstensho@chromium.org> wrote:

Don't propagate early-breaks that would end up in parallel flows.

If a node is known to fit in the current fragmentainer, any break inside
would cause overflow and establish a parallel flow. Such breaks aren't
going to help honor break avoidance requests in the parent / main flow,
so just ignore them.

Note that the test break-between-avoid-012.html also passes without this
CL, but I don't think we had coverage for this case. It's similar to
break-between-avoid-011.html, except that the parallel flow is
established by a float, rather than overflow. This was already passing,
since we don't propagate a lot of things from floats.

Bug: 1337586
Change-Id: I54583e8c5f622b35f81eeb8eb2f9cebbc14f5dd9
Reviewed-on: https://chromium-review.googlesource.com/4002129
WPT-Export-Revision: c8f7da635bedeb48656ded4c1d41c01c37581b54

Component: web-platform-tests → Layout
Product: Testing → Core

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests

Status Summary

Firefox

FAIL: 2

Chrome

PASS: 1
FAIL: 1

Safari

FAIL: 2

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/0d4079af8780 [wpt PR 36801] - Don't propagate early-breaks that would end up in parallel flows., a=testonly https://hg.mozilla.org/integration/autoland/rev/f3f69f2c06f4 [wpt PR 36801] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/0d4079af8780
https://hg.mozilla.org/mozilla-central/rev/f3f69f2c06f4

Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox108: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 108 Branch
You need to log in before you can comment on or make changes to this bug.