Closed Bug 1799015 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 36809 - Revert "Only allow trusted events for light dismiss"

Categories

(Testing :: web-platform-tests, task, P4)

task

Tracking

(firefox108 fixed)

RESOLVED FIXED
108 Branch
Tracking Status
firefox108 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 36809 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/36809
Details from upstream follow.

Devlin Cronin <rdevlin.cronin@chromium.org> wrote:

Revert "Only allow trusted events for light dismiss"

This reverts commit 7e949f5b25185bc150afedadac93ade7780d2b0b.

Reason for revert: [Sheriff] popover-attribute-basic.tentative.html now appears to be flaky on mac.

Original change's description:

Only allow trusted events for light dismiss

Per the conversation at [1], only trusted (i.e. non-synthetic)
events should be used to trigger light dismiss behaviors.

[1] https://github.com/whatwg/html/issues/7785#issuecomment-1299403287

Bug: 1307772
Change-Id: Ia5da594997437a5a620dc2e2b9e928633deabd9f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4000687
Auto-Submit: Mason Freed \<masonf@chromium.org>
Reviewed-by: Joey Arhar \<jarhar@chromium.org>
Commit-Queue: Joey Arhar \<jarhar@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1067199}

Bug: 1307772
Change-Id: Ifbcfa3dc5adb6c4e71e7b5e4f78105a75424ca91
No-Presubmit: true
No-Tree-Checks: true
No-Try: true

Reviewed-on: https://chromium-review.googlesource.com/4004106
WPT-Export-Revision: a447c08fb56f5f86d0136b52b10ba259c518cc72

Whiteboard: [wptsync downstream] → [wptsync downstream error]
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ac613d284c46 [wpt PR 36809] - Revert "Only allow trusted events for light dismiss", a=testonly
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Test result changes from PR not available.
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 108 Branch
You need to log in before you can comment on or make changes to this bug.