1799058 - Setting OffscreenCanvas's width or height must reset the 2D context

Status: VERIFIED FIXED

(Core :: Graphics: Canvas2D, defect, P2)

Description

[Kaiido]

Attachment: test-case.html

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:106.0) Gecko/20100101 Firefox/106.0

Steps to reproduce:

Create a new 2D context from an OffscreenCanvas.
Set a property on this context, e.g its fillStyle, and draw on it.
Set either the width or the height of the OffscreenCanvas to the current value (+= 0).

Actual results:

The context isn't reset, the property isn't reset, the buffer isn't cleared.

Expected results:

Per specs,

If either the width or height attributes of an OffscreenCanvas object are set (to a new value or to the same value as before) and the OffscreenCanvas object's context mode is 2d, then reset the rendering context to its default state and [...
]
(emphasize mine).

The context must be reset, even when set "to the same value as before".

Comment 1

[Bob Hood [:bhood]]

Andrew, could you please have a look?

Comment 2

[Kaiido]

Attachment: Bug 1799058 - Reset context on SetWidth and SetHeight. r=jgilbert

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fd460d08d6ca
Reset context on SetWidth and SetHeight. r=jgilbert

Comment 4

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/fd460d08d6ca

Comment 5

[Ardelean Oana, Desktop QA [:oardelean]]

Reproducible on a 2022-11-03 Nightly build on macOS 12 using the testcase from Comment 0.
Verified as fixed on Firefox 109.0b5(build ID: 20221220185745) and Nightly 110.0a1(build ID: 20221222094520) on macOS 12, Windows 10, Ubuntu 22.