179918 - <script FOR="window"> elements don't load in Mozilla

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect, P1)

Description

[NoFroX]

User-Agent:       Mozilla/4.0 (compatible; MSIE 6.0; Windows NT 5.1)
Build Identifier: 

i use a javascript which reloads the frameset of the website. in actual builds 
it doesn't work. if you click on a link it doesn't jump to the requested link. 
Instead it reloads the default frameset. Furthermore it replaces the orginal 
adress (http://www.pawella.com/) with the request page 
(http://www.pawella.com/index.html?Neulich/Neulich06Mitte.htm) instead of 
keeping the original adress.

The site worked fine with Phoenix 0.4. Problem occurs on Phoenix build 
20021111, 20021112 and Mozilla build 20021108

Reproducible: Sometimes

Steps to Reproduce:
1.go to http://www.pawella.com
2. click picture "negative ...", "Neulich - 500 Euro" or any other link
3.

Actual Results:  
reloads the original frameset. replaces adressline with requested page instead 
of keeping the original adressline.

Expected Results:  
load requested page. keep adressline.

here's the discussed sript:

index.html
      // Sicheres Webseite
      if (self != top) 
      { 
      top.location.href=self.location.href; 
      } 
      var frameset_geladen = "okay"; 
      function laden() 
      { 
      if(self.location.search.length > 0) 
      { 
      var Search_Laenge = self.location.search.length; 
      var info_url = self.location.search.substring(1,Search_Laenge); 
      //self.Mitte.location.href = "../"+info_url;
			self.Mitte.location.href = info_url; 
      } 
      }

Comment 1

[Phil Schwartau]

Browser, not engine ---> Layout

Confirming bug with Mozilla trunk binary 20021107xx on WinNT.
When I load the site, it always comes up blank! 

I don't know why this is. It loads just fine in Mozilla's
Tools > Web Development > DOM Inspector.

In Mozilla itself, each frame at the site loads blank for me
even if I load them as individual URLs:

     http://www.pawella.com/Start/Startmenue.htm
     http://www.pawella.com/Start/StartLogo.htm

Once again, each of these loads fine in the DOM Inspector.
Don't know what's going on here -

Comment 2

[Phil Schwartau]

IGNORE Comment #1; something was wrong with my Mozilla process at the
time I tried the site. The site DOES load fine for me; am now looking
at the links at the site and will report back -

Comment 3

[Phil Schwartau]

The function shown above, laden(), is apparently not recognized in
Mozilla. The function is called from the frameset onload handler.

Yet when I load the site, this error appears in Mozilla's
Tools > Web Development > JavaScript Console:

           Error: laden is not defined


Does it have something to do with the <script> tag used?
<script type="text/javascript" language="JavaScript" FOR="window">

I don't recognize the FOR attribute. Reassigning to DOM Level 0
for further analysis. Another idea: could this be a case of implicit 
document.open()'s clobbering the JS context (bug 114461)?

Comment 4

[Phil Schwartau]

More trouble: the global variable defined just above laden()
is also not recognized in Mozilla:

          var frameset_geladen = "okay";

To see this, load the site in IE6 and in Mozilla, and enter
this javascript:URL:

          javascript: alert(frameset_geladen);  

In IE6, you get "okay"; in Mozilla you get an error in the JS Console:

          Error: frameset_geladen is not defined


This is the direct cause of the reported behavior here. To see this,
use Mozilla's Tools > Web Development > JavaScript Debugger. When we
click on a link in the menu at the site (e.g. "Neulich" > "500 Euro"),
this function gets called in http://www.pawella.com/Scripte/Scripts.js:

function sichereseite()
 -   47  {
 -   48     pfad = self.location.href;
 -   49     pos = pfad.lastIndexOf('/');
 -   50     pfad = pfad.substring(pos+1,pfad.length);
 -   51     var site = "../index.html?"+verz+pfad; 
 -   52     if (top.frameset_geladen + "" != "okay")   
     53     { 
 -   54       if(document.images) 
 -   55  	  top.location.replace(site); 
     56       else 
 -   57         top.location.href = site ; 
     58     } 
     59  }



The check at line 52 fails, since |top.frameset_geladen| == |undefined|.
We fall into line 55, which resets the location. In this example, to:

055: top.location.replace(site);
0001: site
$[0] = [string] "../index.html?Neulich/Neulich10Mitte.htm"


In IE6 this doesn't happen, because |top.frameset_geladen| == "okay".

Comment 5

[Phil Schwartau]

                             SUMMARY

Top-level variables and function definitions are not being recognized
by Mozilla at this site: e.g. the variable |frameset_geladen|.
This is causing problems later on, when menu items are clicked.

This top-level script is contained in a <script> tag in the <head>
above the <frameset>. The tag looks like this:

<script type="text/javascript" language="JavaScript" FOR="window">

Comment 6

[Phil Schwartau]

Again, could this be related to bug 114461?
"document.open() clobbers JS context???"

Comment 7

[NoFroX]

Regarding to Phils comment #3 I checked the for="window" attribute. If I delete 
the attribute it seems to work fine. Please check this with 
http://www.pawella.com/index2.html which has no for="window" attribute. 
http://www.pawella.com/index.html still has the attribute and it doesn't work.

Index2.html works fine with Phoenix original 0.4 and build 20021112 and Mozilla 
20021108.
Index.html works only with Phoenix 0.4. For me it looks like that this behavior 
is introduced after the release of Phoenix 0.4 which is a Mozilla 1.2b build. 
The actual builds are from the Mozilla 1.3a trunk.

Comment 8

[Phil Schwartau]

Confirming what [e-mail] found in Comment #7:

http://www.pawella.com/index2.html, which has no for="window" attribute
on its <script> tag, loads without any errors in the JavaScript Console
and functions perfectly. So it is this attribute that is at issue.

Resummarizing. Is this an HTML Parser instead of a DOM issue?
Why don't we load scripts that have this attribute?

Comment 9

[Peter Van der Beken [:peterv]]

Probably related to the recent checkin to support <script for="...">, see bug
174404.

Comment 10

[Phil Schwartau]

Recall Comment #7:

http://www.pawella.com/index.html still has the for="window" attribute 
http://www.pawella.com/index2.html which has NO for="window" attribute. 

With a Mozilla trunk build 2002-11-15, the latter site works, but
the former doesn't (get "Error: laden is not defined" in JS Console
when you load, which leads to the errors analyzed above, etc.)

Note bug 174404 shows a checkin date of 2002-11-08, yet we still see
this problem with today's trunk build -

Comment 11

[Boris Zbarsky [:bzbarsky]]

*** Bug 181538 has been marked as a duplicate of this bug. ***

Comment 12

[Boris Zbarsky [:bzbarsky]]

To rick.

Comment 13

[Boris Zbarsky [:bzbarsky]]

*** Bug 181759 has been marked as a duplicate of this bug. ***

Comment 14

[rpotts (gone)]

-> jst ;-)

Comment 15

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Regression. Let's try to get this resolved for 1.3beta. It might not be difficult.

Comment 16

[Johnny Stenback (:jst)]

Attachment: Proposed fix

Only treat a script tag as an event handler if it has *both* "for" and "event"
attributes.

Comment 17

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 112800 [details] [diff] [review]
Proposed fix

r=sicking

Comment 18

[Asa Dotzler [:asa]]

Comment on attachment 112800 [details] [diff] [review]
Proposed fix

a=asa (on behalf of drivers) for checkin to 1.3beta.

Comment 19

[Johnny Stenback (:jst)]

Fix checked in. FIXED.

Comment 20

[Boris Zbarsky [:bzbarsky]]

This doesn't fully fix the problem.... see bug 191579

Comment 21

[Johnny Stenback (:jst)]

This fix did indeed fix the regression that was introduced by the plugin events
changes, but there are still problems with <script event=onload for=window>.
Those problems are however not related to this regression.