Closed
Bug 1799202
Opened 3 years ago
Closed 3 years ago
Port bug 1798743: Handle use of $AddPrivateBrowsingSC in shared NSIS code
Categories
(Firefox :: Installer, defect)
Firefox
Installer
Tracking
()
RESOLVED
FIXED
108 Branch
| Tracking | Status | |
|---|---|---|
| firefox-esr102 | --- | unaffected |
| firefox106 | --- | unaffected |
| firefox107 | --- | unaffected |
| firefox108 | --- | fixed |
People
(Reporter: rjl, Assigned: rjl)
References
(Regression)
Details
(Keywords: regression)
Attachments
(1 file)
|
48 bytes,
text/x-phabricator-request
|
Details |
Changes to toolkit/mozapps/installer/windows/nsis/common.nsh in bug 1798743 require that a $AddPrivateBrowsingSC be set.
For Thunderbird, "Private Browsing" isn't a thing. The code that uses the variable to add the private browser shortcut is in browser/installer/windows/nsis/installer.nsi. There will still be an argument to pass to the resulting setup.exe but Thunderbird's installer will just ignore it.
|
||
Updated•3 years ago
|
Keywords: regression
|
Assignee | |
Comment 1•3 years ago
|
||
Private browsing doesn't make sense for Thunderbird. Wrap the use of
$AddPrivateBrowsingSC to avoid breaking the installer build.
|
|
Assignee | |
Updated•3 years ago
|
Component: Upstream Synchronization → Installer
Product: Thunderbird → Firefox
|
|
||
Comment 2•3 years ago
|
||
Set release status flags based on info from the regressing bug 1798743
status-firefox106:
--- → unaffected
status-firefox107:
--- → unaffected
status-firefox108:
--- → affected
status-firefox-esr102:
--- → unaffected
Pushed by thunderbird@calypsoblue.org:
https://hg.mozilla.org/integration/autoland/rev/ccdf2a413c5c
Wrap use of $AddPrivateBrowsingSC with !ifdef in shared installer code. r=bhearsum
|
||
Comment 4•3 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 108 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•