1799246 - macOS Window menu items enabled when they should be disabled

Status: REOPENED

(Core :: Widget: Cocoa, defect, P3)

Description

[Sam Johnson]

Attachment: finder.png

After bug 1642138, many menu items that are non-functional and should be disabled are not disabled. I have attached screenshots comparing Firefox's Window menu and Finder's Window menu as an example.

Comment 1

[Sam Johnson]

Attachment: fx.png

Comment 2

[Sam Johnson]

Also, it looks like Minimize and Zoom are incorrectly ordered in Firefox's menu.

Comment 3

[Stephen A Pohl [:spohl]]

(In reply to Sam Johnson from comment #2)

Also, it looks like Minimize and Zoom are incorrectly ordered in Firefox's menu.

Yes, this is something that I could not find a way to work around but also doesn't seem like a dramatic functionality issue. We could file a separate bug for it to try and find a better solution, but it shouldn't prevent us from enabling the OS-supplied functionality.

Comment 4

[Stephen A Pohl [:spohl]]

(In reply to Sam Johnson from comment #0)

Created attachment 9302126 [details]
finder.png

After bug 1642138, many menu items that are non-functional and should be disabled are not disabled. I have attached screenshots comparing Firefox's Window menu and Finder's Window menu as an example.

Which items specifically are non-functional and should be disabled?

Comment 5

[Sam Johnson]

(In reply to Stephen A Pohl [:spohl] from comment #4)

Which items specifically are non-functional and should be disabled?

Replace Tiled Window, and Remove Window from Set. I believe this are specific to Stage Manager, which I do not have enabled.

Comment 6

[Stephen A Pohl [:spohl]]

(In reply to Stephen A Pohl [:spohl] from comment #4)

(In reply to Sam Johnson from comment #0)

Created attachment 9302126 [details]
finder.png

After bug 1642138, many menu items that are non-functional and should be disabled are not disabled. I have attached screenshots comparing Firefox's Window menu and Finder's Window menu as an example.

Which items specifically are non-functional and should be disabled?

Oh, you mean "Replaced Tiled Window" and "Remove Window from Set" for example? Interesting. Thanks for filing.

Comment 7

[Stephen A Pohl [:spohl]]

Fixed by backout of bug 1642138.

Comment 8

[Stephen A Pohl [:spohl]]

I'm landing an updated patch in bug 1642138 and this will start occurring again. I'm reopening this bug to investigate further without blocking the landing of bug 1642138.

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1642138

Comment 10

[Dianna Smith [:diannaS]]

Is the plan to fix this in 108? As a reminder merge day is on Monday.

Comment 11

[Haik Aftandilian [:haik]]

Stephen is not planning to address the extra menu items before the merge.

Comment 12

[Greg Hess]

Hi Steven, can you clarify the status of this issue please.

Comment 13

[Stephen A Pohl [:spohl]]

This is a valid issue that we will resolve as time permits. There is no particular reason to track this for any specific release.