1799252 - Crash in [@ mozilla::WaylandVsyncSource::FrameCallback]

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect, P3)

Description

[Matt Fagnani]

I was using Firefox Nightly 108.0a1 on Wayland with WebRender compositing in a Fedora 37 KDE Plasma installation. I had instagram.com pages in two tabs open. I switched from Firefox to Konsole and back. I might have closed the second tab when Firefox crashed with a failed assertion MOZ_RELEASE_ASSERT(aCallback == mCallback). This assertion looked to be added for Bug 1796130 which was first in 108.0a1 20221104160427 https://hg.mozilla.org/mozilla-central/rev/164d45cee724 Firefox crashed a few minutes later with the same failed assertion when I was trying to report this bug here and I switched from Firefox to Thunderbird Daily 108.0a1 and back to Firefox https://crash-stats.mozilla.org/report/index/78de3e08-db2b-4fc7-bb2b-947460221105

Crash report: https://crash-stats.mozilla.org/report/index/0ba7e0a3-cb3c-44f6-91ae-b620f0221105

MOZ_CRASH Reason: MOZ_RELEASE_ASSERT(aCallback == mCallback)

Top 10 frames of crashing thread:

0  libxul.so  mozilla::WaylandVsyncSource::FrameCallback  widget/gtk/WaylandVsyncSource.cpp:307
1  libxul.so  mozilla::WaylandVsyncSourceCallbackHandler  widget/gtk/WaylandVsyncSource.cpp:42
2  libffi.so.8  ffi_call_unix64  
3  libffi.so.8  ffi_call_int  /usr/src/debug/libffi-3.4.2-9.fc37.x86_64/src/x86/ffi64.c:672
4  libwayland-client.so.0  wl_closure_invoke  /usr/src/debug/wayland-1.21.0-1.fc37.x86_64/src/connection.c:1025
5  libwayland-client.so.0  dispatch_event  /usr/src/debug/wayland-1.21.0-1.fc37.x86_64/src/wayland-client.c:1595
6  libwayland-client.so.0  dispatch_queue  /usr/src/debug/wayland-1.21.0-1.fc37.x86_64/src/wayland-client.c:1741
6  libwayland-client.so.0  wl_display_dispatch_queue_pending  /usr/src/debug/wayland-1.21.0-1.fc37.x86_64/src/wayland-client.c:1983
7  libgdk-3.so.0  _gdk_wayland_display_queue_events  /usr/src/debug/gtk3-3.24.34-2.fc37.x86_64/gdk/wayland/gdkeventsource.c:201
8  libgdk-3.so.0  gdk_display_get_event  /usr/src/debug/gtk3-3.24.34-2.fc37.x86_64/gdk/gdkdisplay.c:442

Comment 1

[Matt Fagnani]

This problem started with 108.0a1 20221104160427 in Plasma 5.26.2.

Comment 2

[Asif Youssuff]

19:50.92 INFO: No more integration revisions, bisection finished.
19:50.92 INFO: Last good revision: 724283f0eff6a4dc3159b3f20f728f173e3202d9
19:50.92 INFO: First bad revision: 164d45cee72436a8f82c1cd8b73e49538a627f29
19:50.92 INFO: Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=724283f0eff6a4dc3159b3f20f728f173e3202d9&tochange=164d45cee72436a8f82c1cd8b73e49538a627f29

Also seeing this.

Additional crashes:

bp-8ca73fb4-e02e-4d7a-8449-557300221105
bp-a56bba93-fac0-41c1-8408-7eee10221105
bp-c6db0138-f976-48d9-b3c3-685b90221105
bp-52e4355c-63c7-473b-b0fd-011410221105

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1796130

:stransky, since you are the author of the regressor, bug 1796130, could you take a look? Also, could you set the severity field?

For more information, please visit auto_nag documentation.

Comment 4

[Martin Stránský [:stransky] (ni? me)]

Can you try mutter compositor? I wonder why we're getting different callbacks here.
Thanks.

Comment 5

[Martin Stránský [:stransky] (ni? me)]

btw: Mutter how-to is here:
https://fedoraproject.org/wiki/How_to_debug_Firefox_problems#Testing_different_Wayland_compositor
Thanks.

Comment 6

[Asif Youssuff]

Martin, here is a crash while running within mutter: bp-a9f03cd6-55df-4580-9a57-906200221105

Thanks!

Comment 7

[Olli Pettay [:smaug][[e-mail]]]

Looks like nightly is crashing now all the time for me, shortly after startup. This is on up-to-date Fedora 35 ( with Gnome)

Comment 8

[Cosmin Sabou [:CosminS]]

Hopefully this should be fixed with https://hg.mozilla.org/mozilla-central/rev/2dfe4630c45a7959d39dea8cbf5a8457e36dc64b and new nightlies incoming. Reopen if it needed.

Comment 9

[Matt Fagnani]

(In reply to Martin Stránský [:stransky] (ni? me) from comment #4)

Can you try mutter compositor? I wonder why we're getting different callbacks here.
Thanks.

Firefox 108.0a1 20221105092350 on Wayland crashed with this failed assertion in GNOME 43.0 in Fedora 37 when I switched from it to GNOME System Settings then back to Firefox https://crash-stats.mozilla.org/report/index/2b7c0edb-8f09-4dde-98a0-b50cd0221105 108.0a1 20221104160427 crashed with this failed assertion when I switched from it to Konsole and then back to Firefox in Plasma 5.26.2 https://crash-stats.mozilla.org/report/index/5d615a76-2539-495f-b07f-0bbc60221105 So the problem seemed to occur when I switched from another program's window back to Firefox. Thanks.