Closed
Bug 1799255
Opened 3 years ago
Closed 3 years ago
Revert the SyncedTabs lastUsed change and any changes from consumers
Categories
(Firefox :: Sync, defect)
Firefox
Sync
Tracking
()
RESOLVED
FIXED
108 Branch
| Tracking | Status | |
|---|---|---|
| firefox108 | --- | fixed |
People
(Reporter: skhamis, Assigned: skhamis)
References
Details
(Whiteboard: [fxsync-])
Attachments
(1 file)
In bug 1798879, it was mentioned that the changing of SyncedTabs lastUsed method broke Firefox View. There could be other consumers that are broken, and since there are no tests to safe guard against this -- would be difficult to find (without a manual search). In addition to having tests catch this in the future, the two options we have are:
(1)
- Revert the change to the
lastUsedfield - Revert any changes consumers needed to make in this
- Implement tests in all callers of SyncedTabs to ensure this doesn't happen
(2)
- Continue with the change and identify any additional callers that need to be changed
- Implement tests in all callers of SyncedTabs to ensure this doesn't happen
|
Assignee | |
Updated•3 years ago
|
QA Whiteboard: [fxsync-]
|
|
Assignee | |
Updated•3 years ago
|
QA Whiteboard: [fxsync-]
Whiteboard: [fxsync-]
|
||
Updated•3 years ago
|
|
|
Assignee | |
Comment 1•3 years ago
|
||
|
||
Updated•3 years ago
|
Assignee: nobody → skhamis
Status: NEW → ASSIGNED
Pushed by skhamis@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3f764d04e906
Revert the SyncedTabs lastUsed change and any changes from consumers r=markh,sfoster
|
||
Comment 3•3 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox108:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 108 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•