Closed Bug 1799316 Opened 3 years ago Closed 3 years ago

Console errors when manually updating addons

Categories

(Toolkit :: Add-ons Manager, defect)

Product:
Toolkit
Component:
Add-ons Manager
Version:
Firefox 106
Type:
defect

Tracking

()

Status:
RESOLVED WORKSFORME

People

(Reporter: siffe, Unassigned)

Details

User Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:106.0) Gecko/20100101 Firefox/106.0

Steps to reproduce:

  • open add-ons manager
  • click options gear
  • click 'Check for updates'

Actual results:

Until a couple of days ago, if there was no update it would take almost a minute to return 'No updates found'.

In the browser console Log tab, this error was logged after clicking 'Check for updates' every time:

1667519594302 addons.update-checker WARN onUpdateCheckComplete failed to parse update manifest: [Exception... "Update manifest is missing a required addons property." nsresult: "0x80004005 (NS_ERROR_FAILURE)" location: "JS frame :: resource://gre/modules/addons/AddonUpdateChecker.jsm :: getRequiredProperty :: line 149" data: no] Stack trace: getRequiredProperty()@resource://gre/modules/addons/AddonUpdateChecker.jsm:149
parseJSONManifest()@resource://gre/modules/addons/AddonUpdateChecker.jsm:165
onLoad()@resource://gre/modules/addons/AddonUpdateChecker.jsm:343
UpdateParser/<()@resource://gre/modules/addons/AddonUpdateChecker.jsm:286

Expected results:

'No updates found' should have been returned within 3-5 seconds as usual. This appears to be OK now, but the error is still being logged. In addition, this is loggged on every startup:

1667519406676 addons.xpi WARN Checking C:\Program Files\Mozilla\Firefox\distribution\extensions for addons

ExtensionPreferencesManager API ftpProtocolEnabled created but addSetting was not called.

The Bugbug bot thinks this bug should belong to the 'Toolkit::Add-ons Manager' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Component: Untriaged → Add-ons Manager
Product: Firefox → Toolkit

Hello,

I could not reproduce the issue on the latest Nightly (108.0a1/20221106212619) or Release (106.0.5/20221104133228). The mentioned error is not logged to console when manually checking for add-on updates and “No updates found” is returned almost immediately when clicking “Check for Updates”.

The only thing that appears on my end in the console, is “1667804187307 addons.xpi WARN Checking C:\Program Files\Mozilla Firefox\distribution\extensions for addons”

  • Happens on release, beta, and nightly, which all have the same addons.
  • I forgot to mention that it also happened on Thunderbird until I removed UBlock Origin, which had been disabled.
  • Doesn't happen on developer, which has only a few of the same addons as the other FFs including UBO.
  • Removing UBO from beta and disabling all other addons didn't stop the logging.

Guess it's not worth pursuing further unless the 'No updates found' delay starts up again.

As per Comment 3, I’ll be closing this as WORKSFORME.

Please reopen in case the “No updates found” delay issue starts again. Thank you !

Status: UNCONFIRMED → RESOLVED
Closed: 3 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.